[skrifa] Don't enable traversal feature by default - #1666
Merged
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
dfrg
approved these changes
Sep 19, 2025
dfrg
left a comment
dfrg
left a comment
Contributor
There was a problem hiding this comment.
I believe keeping this enabled by default was an oversight. LGTM
dfrg
added a commit
that referenced
this pull request
Nov 9, 2025
Changes for font-types from font-types-v0.10.0 to 0.10.1
654503c Negation overflow in Fixed::div (#1662)
Changes for read-fonts from read-fonts-v0.35.0 to 0.35.1
b022894 [read-fonts+skrifa] CFF: clear stem hints for seac components (#1688)
0bd210e [read-fonts] CFF: ignore unknown operators (#1687)
8b20dfd [read-fonts] CFF: relax stack checks (#1686)
0a82dd4 Handle NO_VARIATION_INDEX case when computing deltas, fixes #1720
2edf2f2 [klippa] subset GSUB/GPOS tables
a747f45 Fix clippy::obfuscated_if_else lint
244c4ec Fix mismatched lifetimes syntax warning
1b5175d [read-fonts] add mapping/iter support to CmapSubtable (#1656)
caab2c5 [read-fonts] extend support for cmap 6 and 10 (#1655)
707ebc8 Add CPAL interface in skrifa (#1632)
Changes for skrifa from skrifa-v0.37.0 to 0.37.1
b022894 [read-fonts+skrifa] CFF: clear stem hints for seac components (#1688)
8b6497d [skrifa] Make traversal feature non-default (#1666)
237e696 Add with overflow in CFF hint scale computation (#1665)
512ae1c Subtract overflow in autohint State::apply_to_segment (#1664)
a6e7e45 Add with overflow in ColrInstance::var_deltas (#1663)
707ebc8 Add CPAL interface in skrifa (#1632)
dfrg
added a commit
that referenced
this pull request
Nov 9, 2025
Changes for font-types from font-types-v0.10.0 to 0.10.1
654503c Negation overflow in Fixed::div (#1662)
Changes for read-fonts from read-fonts-v0.35.0 to 0.35.1
b022894 [read-fonts+skrifa] CFF: clear stem hints for seac components (#1688)
0bd210e [read-fonts] CFF: ignore unknown operators (#1687)
8b20dfd [read-fonts] CFF: relax stack checks (#1686)
0a82dd4 Handle NO_VARIATION_INDEX case when computing deltas, fixes #1720
2edf2f2 [klippa] subset GSUB/GPOS tables
a747f45 Fix clippy::obfuscated_if_else lint
244c4ec Fix mismatched lifetimes syntax warning
1b5175d [read-fonts] add mapping/iter support to CmapSubtable (#1656)
caab2c5 [read-fonts] extend support for cmap 6 and 10 (#1655)
707ebc8 Add CPAL interface in skrifa (#1632)
Changes for skrifa from skrifa-v0.37.0 to 0.37.1
b022894 [read-fonts+skrifa] CFF: clear stem hints for seac components (#1688)
8b6497d [skrifa] Make traversal feature non-default (#1666)
237e696 Add with overflow in CFF hint scale computation (#1665)
512ae1c Subtract overflow in autohint State::apply_to_segment (#1664)
a6e7e45 Add with overflow in ColrInstance::var_deltas (#1663)
707ebc8 Add CPAL interface in skrifa (#1632)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves compile times of
read-fontsby around 25% (8s -> 6s on my machine) for cases where thetraversalfeature is not required.See #1658 (comment)