Skip to content

fix(manifest): apply per-package snapshot-label from config #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LudovicTOURMAN wants to merge 1 commit into
base: main
Choose a base branch
from
+47 −0
Open

fix(manifest): apply per-package snapshot-label from config #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,6 +1422,7 @@ function extractReleaserConfig(
labels: config['label']?.split(','),
releaseLabels: config['release-label']?.split(','),
extraLabels: config['extra-label']?.split(','),
snapshotLabels: config['snapshot-label']?.split(','),
skipSnapshot: config['skip-snapshot'],
initialVersion: config['initial-version'],
excludePaths: config['exclude-paths'],
Expand Down Expand Up @@ -1790,6 +1791,7 @@ function mergeReleaserConfig(
skipSnapshot: pathConfig.skipSnapshot ?? defaultConfig.skipSnapshot,
initialVersion: pathConfig.initialVersion ?? defaultConfig.initialVersion,
extraLabels: pathConfig.extraLabels ?? defaultConfig.extraLabels,
snapshotLabels: pathConfig.snapshotLabels ?? defaultConfig.snapshotLabels,
excludePaths: pathConfig.excludePaths ?? defaultConfig.excludePaths,
dateFormat: pathConfig.dateFormat ?? defaultConfig.dateFormat,
};
Expand Down
13 changes: 13 additions & 0 deletions test/fixtures/manifest/config/snapshot-labels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"release-type": "java",
"snapshot-label": "global-snapshot",
"packages": {
".": {
"component": "root"
},
"node-lib": {
"component": "node-lib",
"snapshot-label": "per-package-snapshot"
}
}
}
32 changes: 32 additions & 0 deletions test/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,38 @@ describe('Manifest', () => {
'lang: nodejs',
]);
});
it('should read snapshot labels from manifest', async () => {
const getFileContentsStub = sandbox.stub(
github,
'getFileContentsOnBranch'
);
getFileContentsStub
.withArgs('release-please-config.json', 'main')
.resolves(
buildGitHubFileContent(
fixturesPath,
'manifest/config/snapshot-labels.json'
)
)
.withArgs('.release-please-manifest.json', 'main')
.resolves(
buildGitHubFileContent(
fixturesPath,
'manifest/versions/versions.json'
)
);
const manifest = await Manifest.fromManifest(
github,
github.repository.defaultBranch
);
expect(manifest['snapshotLabels']).to.deep.equal(['global-snapshot']);
expect(manifest.repositoryConfig['.'].snapshotLabels).to.deep.equal([
'global-snapshot',
]);
expect(
manifest.repositoryConfig['node-lib'].snapshotLabels
).to.deep.equal(['per-package-snapshot']);
});
it('should read exclude paths from manifest', async () => {
const getFileContentsStub = sandbox.stub(
github,
Expand Down
Loading