Skip to content

feat: call fetchToken in startChat to speed up the first message response #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrobinson01 wants to merge 1 commit into
base: main
Choose a base branch
from
+126 −82
Open

feat: call fetchToken in startChat to speed up the first message response #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/models/generative_models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export class GenerativeModel {
* @param request - {@link StartChatParams}
* @returns {@link ChatSession}
*/
startChat(request?: StartChatParams): ChatSession {
async startChat(request?: StartChatParams): Promise<ChatSession> {
const startChatRequest: StartChatSessionRequest = {
project: this.project,
location: this.location,
Expand All @@ -273,6 +273,7 @@ export class GenerativeModel {
startChatRequest.systemInstruction =
request.systemInstruction ?? this.systemInstruction;
}
await this.fetchToken();
return new ChatSession(startChatRequest, this.requestOptions);
}
}
Expand Down
Loading