Skip to content

feat: enable mypy session for documentai-toolbox #16690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalmerlowe merged 17 commits into from
Apr 21, 2026
Merged

feat: enable mypy session for documentai-toolbox #16690

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
cccd359
feat: enable mypy session for documentai-toolbox
chalmerlowe Apr 16, 2026
6abd528
fix(documentai-toolbox): resolve mypy errors
chalmerlowe Apr 17, 2026
cbbacda
chore(documentai-toolbox): fix linting and formatting
chalmerlowe Apr 17, 2026
20d9ae8
fix(documentai-toolbox): move type ignore to correct line in gcs_util…
chalmerlowe Apr 17, 2026
67eb298
feat(documentai-toolbox): use ConfigOrData type alias for Block fields
chalmerlowe Apr 17, 2026
3ca1496
feat(documentai-toolbox): update ConfigOrData to include List and use…
chalmerlowe Apr 17, 2026
c2c4e4e
fix(documentai-toolbox): replace assert with explicit check in gcs_ut…
chalmerlowe Apr 17, 2026
1dea669
fix(documentai-toolbox): replace redundant cast with isinstance check…
chalmerlowe Apr 17, 2026
5c1fe11
style: blacken block.py
chalmerlowe Apr 17, 2026
94a5f3e
fix(documentai-toolbox): use specific types for Block fields and reve…
chalmerlowe Apr 17, 2026
1a972f0
fix(documentai-toolbox): fix mypy errors in block.py and bbox_convers…
chalmerlowe Apr 17, 2026
7126d34
fix(documentai-toolbox): fix remaining mypy errors in bbox_conversion.py
chalmerlowe Apr 17, 2026
f8312eb
style: blacken and format documentai-toolbox files
chalmerlowe Apr 17, 2026
bddf806
fix(documentai-toolbox): expect dict for bounding_box in Type 2 in bb…
chalmerlowe Apr 17, 2026
49a17b1
fix(documentai-toolbox): allow both list and dict for entities in blo…
chalmerlowe Apr 17, 2026
410c1ad
fix(documentai-toolbox): fix mypy error for storage import in gcs_uti…
chalmerlowe Apr 17, 2026
ff8695d
fix(lint): remove unused SimpleNamespace import in bbox_conversion.py
chalmerlowe Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/google-cloud-documentai-toolbox/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,21 @@ def prerelease_deps(session, protobuf_implementation):
@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run the type checker."""

# TODO(https://github.com/googleapis/google-cloud-python/issues/16014):
# Enable mypy once this bug is fixed.
session.skip("Temporarily skip mypy. See issue 16014")
session.install(
"mypy<1.16.0",
Comment thread
chalmerlowe marked this conversation as resolved.
"types-requests",
"types-protobuf",
"pandas-stubs",
)
session.install("-e", ".")
session.run(
"mypy",
"-p",
"google.cloud.documentai_toolbox",
"--check-untyped-defs",
"--ignore-missing-imports",
*session.posargs,
)
Comment thread
chalmerlowe marked this conversation as resolved.


@nox.session(python=DEFAULT_PYTHON_VERSION)
Expand Down
Loading