refactor(checkpoint-object-manager): deprecate C++ object_manager layer for lightweight Python subprocess async deletion#102
Merged
Leahlijuan merged 5 commits intomainfrom Apr 23, 2026
Conversation
g-husam
reviewed
Apr 16, 2026
g-husam
approved these changes
Apr 22, 2026
g-husam
reviewed
Apr 22, 2026
| return p | ||
| except Exception as e: | ||
| _LOGGER.exception("Background deletion of old checkpoints failed: %s", e) | ||
| return None |
Collaborator
There was a problem hiding this comment.
hm ideally we'd at least return something that informs the caller there was an error. Otherwise they can't distinguish between "nothing to do" and "failed to delete".
Maybe bubble up the exception? Or can return a wrapper type encapsulating an Optional proc and an optional error e.g.
@dataclass
class DeletionResult:
proc: Optional[subprocess.Popen] = None
error: Optional[Exception] = None
skipped: bool = FalseNot a blocker, but will make the API more explicit.
Then in the failure test, we can confirm there was an error by asserting on the result, as opposed to just expecting proc to be None, which is the same expectation when there is no error and nothing to do.
Python Code Coverage Summary
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: deprecate C++ object_manager layer for lightweight Python subprocess async deletion
This patch modernizes the ML-Flashpoint directory deletion lifecycle by fully replacing the native C++
object_managermodule with streamlinedsubprocess.Popencalls. This drastically simplifies the codebase overhead during checkpoint cleanup routines.