Skip to content

Improved TPanic message for Android #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulorrfilho wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Improved TPanic message for Android #9885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/utils/src/Panic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
#include <new>
#include <string_view>
#include <utility>
#if defined(__ANDROID__)
# include <android/set_abort_message.h>
#endif

namespace utils {

Expand Down Expand Up @@ -222,6 +225,13 @@ void TPanic<T>::panic(char const* function, char const* file, int line, char con
// Call the user provided handler
UserPanicHandler::get().call(e);

// Register the full panic message as the tombstone "Abort message:" so that it
// appears in crash reports collected by Google Play Console and other tools that
// read tombstones from field devices (which never have access to logcat output).
#if defined(__ANDROID__)
android_set_abort_message(e.what());
#endif

Comment on lines +228 to +234
Copy link
Copy Markdown
Collaborator

@pixelflinger pixelflinger Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved just above the std::abort() call, and after the throw e (if exceptions are enabled, we might not abort).

// if exceptions are enabled, throw now.
#ifdef __EXCEPTIONS
throw e;
Expand Down
Loading