Improved TPanic message for Android#9885
Open
paulorrfilho wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
Register the full panic message as the tombstone “Abort message:” so it appears in crash reports (e.g., Google Play Console) that rely on device tombstones instead of logcat output.
Contributor
pixelflinger
requested changes
Apr 13, 2026
Comment on lines
+228
to
+234
| // Register the full panic message as the tombstone "Abort message:" so that it | ||
| // appears in crash reports collected by Google Play Console and other tools that | ||
| // read tombstones from field devices (which never have access to logcat output). | ||
| #if defined(__ANDROID__) | ||
| android_set_abort_message(e.what()); | ||
| #endif | ||
|
|
Collaborator
There was a problem hiding this comment.
this should be moved just above the std::abort() call, and after the throw e (if exceptions are enabled, we might not abort).
pixelflinger
requested changes
Apr 14, 2026
Collaborator
pixelflinger
left a comment
pixelflinger
left a comment
There was a problem hiding this comment.
Unfortunately android_set_abort_message() is not an official public API. However:
__android_log_default_aborter(const char *abort_message)
Seems to be a public API as of API level 30.
So, we should be able to use __android_log_default_aborter instead of abort() on android if we surround the code with
if (__builtin_available(android 30, *)) {
}
(on Android only).
If we're not on API level 30, then as a workaround, we can maybe use android_set_abort_message() + abort(). But we have to be careful. The best way would be to do this:
extern "C" __attribute__((weak)) void android_set_abort_message(const char *);
if (&android_set_abort_message) {
android_set_abort_message(str);
}
and avoid including the header entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the full panic message as the tombstone “Abort message:” so it appears in crash reports (e.g., Google Play Console) that rely on device tombstones instead of logcat output.
Related to #9294 #9075