FL0 materials are always compiled via spirv-cross#9867
Merged
pixelflinger merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
pixelflinger
force-pushed
the
ma/FL0-postfx-rec709
branch
from
514e516 to
6a920d3
Compare
pixelflinger
force-pushed
the
ma/FL0-improvements
branch
from
47ed72b to
18f23c4
Compare
poweifeng
approved these changes
Apr 2, 2026
romainguy
reviewed
Apr 2, 2026
| // preampitively forbid spirv-cross from cheating and polyfilling disabled features | ||
| auto const& exts = glslCompiler.get_required_extensions(); | ||
| for (auto const& ext : exts) { | ||
| if (ext != "GL_OES_standard_derivatives" && |
Contributor
There was a problem hiding this comment.
You should have a map/set of allowed extensions and just do an if (!allowedMap.contains(ext)). It'll make it easier to track/maintain the list of extension instead of finding this somewhat random piece of code.
Contributor
There was a problem hiding this comment.
You should just write 1.0 / 2.2, I think it's a bit more obvious for the reader (also what we use in other places that do sRGB conversion).
| #if MATERIAL_FEATURE_LEVEL == 0 | ||
| if (CONFIG_SRGB_SWAPCHAIN_EMULATION) { | ||
| if (frameUniforms.rec709 != 0) { | ||
| fragColor.rgb = pow(fragColor.rgb, vec3(0.45454)); |
bejado
approved these changes
Apr 2, 2026
pixelflinger
force-pushed
the
ma/FL0-improvements
branch
from
18f23c4 to
2a34749
Compare
pixelflinger
changed the title
pixelflinger
force-pushed
the
ma/FL0-improvements
branch
from
2a34749 to
79f5686
Compare
pixelflinger
force-pushed
the
ma/FL0-improvements
branch
from
79f5686 to
9809f4f
Compare
copybara-service bot
pushed a commit
to google-deepmind/mujoco
that referenced
this pull request
Apr 14, 2026
… due to FL0 now going through `spirv-cross`. This is an early upload of google/filament#9867 and necessary material changes Original PR commits: FL0 materials are always compile via spirv-cross postfx materials now support sRGB emulation in FL0 PiperOrigin-RevId: 899262890 Change-Id: I52c002d60790d84269674c1f0d0c5f7d6a58000c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.