fix(algolia): don't fail to populate search container if one is "missing" - #2699
Open
msvticket wants to merge 1 commit into
Open
fix(algolia): don't fail to populate search container if one is "missing"#2699msvticket wants to merge 1 commit into
msvticket wants to merge 1 commit into
Conversation
…ing" Upgrading docsearch since v3 isn't maintained indexName is deprecated: https://docsearch.algolia.com/docs/api#indexname Removing integrity as per https://www.jsdelivr.com/using-sri-with-dynamic-files
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all search containers might exist on a page. In that case an error like this is visible in the console:
If it's
#docsearch-0that is missing,#docsearch-1won't be populated even if it does exist.My case
At https://jayex.io/ we are currently using custom code for Algolia but while I'm in the process of upgrading hugo and docsy I'm trying to switch to as much standard features as possible. The result for algolia was that the searchbox disappeared on the front page since it is configured to have no sidebars. Here is a link to my preview: https://jx-docs-jx-jayex-io-jx-docs-pr-19.infra.jenkins-x.rocks/
Maintenance
While fixing this I thought I'd do some maintenance as well: