Repository navigation
Threshold ERA5 land fractions in public benchmark regions - #326
Draft
sylvesterkaczmarek wants to merge 2 commits into
Draft
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316.
Convert the ERA5 land fraction to a boolean
>= 0.5mask before passing it tobinning.Regionsin the public benchmark. This matches the existingbinning.LandSeaconvention and prevents mostly-ocean cells from being counted as land. TheRegionsAPI and the non-land regional masks are unchanged.Add regression tests that execute the actual benchmark entrypoint with dataset loading and pipeline execution mocked. They inspect the real aggregator and cover fractional values, the 0.5 boundary, NaNs, reversed latitude, binary-mask compatibility and unchanged non-land regions. A synthetic RMSE case changes from the incorrect land-only value of 6 to 2, while global RMSE remains 6. The regression test is now under
weatherbenchX/, so the existingpytest weatherbenchXcommand discovers it without changing the workflow.Validation on Python 3.11:
test_tmpdirerrors with this environment's Abseil version; the same error was reproduced in a separate unmodified upstream checkout. No unrelated test-runner change is included.weatherbenchX/public_benchmark_test.py, all four focused regression cases passed on Python 3.12. Existing test discovery picked up these four cases among 269 collected tests. The Google workflow-security scan passed on the new commit; hosted project CI still requires maintainer approval.git diff --checkpassed.Existing published land-region results were not recomputed or replaced. Regenerating those results will change their land-region scores and requires maintainer coordination; non-land regions retain their masks. No ERA5 or forecast dataset was downloaded, no cloud pipeline was submitted, and no published benchmark data was modified.
To reproduce the full local test launch when Abseil flags are not initialized by the runner: