Repository navigation
Respect delta tolerance in Prune and forward it from pruned Determinize. - #430
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
copybara/1025691073
branch
from
November 19, 2026 19:54
e02dd52 to
272bde0
Compare
`Prune` previously compared path weights against the pruning limit with exact `NaturalLess`, ignoring `PruneOptions::delta`. Pruned `Determinize` also omitted `opts.delta` when calling `ShortestDistance` and `Prune`. With floating-point weights, residual quantization in `Determinize` or `Times` rounding can push an optimal path slightly above the exact limit and prune it. Compare final and arc path weights within `opts.delta` via `ApproxEqual` in both `Prune` overloads, and forward `opts.delta` in pruned `Determinize`. Also guard `weight_threshold` below `Weight::One()` and unset start states up front in destructive `Prune`, matching constructive `Prune`. PiperOrigin-RevId: 1025691073
copybara-service
Bot
force-pushed
the
copybara/1025691073
branch
from
November 19, 2026 20:49
272bde0 to
2aca142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect delta tolerance in Prune and forward it from pruned Determinize.
Prunepreviously compared path weights against the pruning limit with exactNaturalLess, ignoringPruneOptions::delta. PrunedDeterminizealso omittedopts.deltawhen callingShortestDistanceandPrune. With floating-point weights, residual quantization inDeterminizeorTimesrounding can push an optimal path slightly above the exact limit and prune it.Compare final and arc path weights within
opts.deltaviaApproxEqualin bothPruneoverloads, and forwardopts.deltain prunedDeterminize. Also guardweight_thresholdbelowWeight::One()and unset start states up front in destructivePrune, matching constructivePrune.