Skip to content

Reduce blank lines.#25563

Merged
gundermanc merged 2 commits intomainfrom
gundermanc/blank-line
Apr 17, 2026
Merged

Reduce blank lines.#25563
gundermanc merged 2 commits intomainfrom
gundermanc/blank-line

Conversation

@gundermanc
Copy link
Copy Markdown
Member

Summary

Delete the blank lines preceding the topic UX.

@gundermanc gundermanc requested a review from a team as a code owner April 16, 2026 22:29
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the UI layout by removing unnecessary blank lines preceding topic messages. This change ensures a more compact and consistent visual presentation within the tool group message component.

Highlights

  • UI Layout Adjustment: Removed the top margin from the Box component wrapping the TopicMessage to reduce vertical spacing.
  • Snapshot Updates: Updated test snapshots to reflect the changes in UI spacing for topic tool calls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@Abhijit-2592 Abhijit-2592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the top margin from the TopicMessage component within ToolGroupMessage and updates the associated test snapshots. A review comment identifies that this change creates a discrepancy with the staticHeight calculation logic, which still accounts for the removed margin. This inconsistency needs to be addressed to prevent potential layout and scrolling issues in the terminal UI.

Comment thread packages/cli/src/ui/components/messages/ToolGroupMessage.tsx
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Size Change: -22 B (0%)

Total Size: 33.6 MB

Filename Size Change
./bundle/chunk-2NYO72XA.js 0 B -14.5 MB (removed) 🏆
./bundle/chunk-GATT3L4F.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-XAAXS7FC.js 0 B -3.43 MB (removed) 🏆
./bundle/core-5YERAVXS.js 0 B -46.7 kB (removed) 🏆
./bundle/devtoolsService-O6TCGQDE.js 0 B -28.4 kB (removed) 🏆
./bundle/gemini-PBZUFHER.js 0 B -553 kB (removed) 🏆
./bundle/interactiveCli-A7ZSV52R.js 0 B -1.29 MB (removed) 🏆
./bundle/oauth2-provider-DVFXEZ4D.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-MF663GJ5.js 3.43 MB +3.43 MB (new file) 🆕
./bundle/chunk-WSTYC5AW.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-ZUZDM53G.js 14.5 MB +14.5 MB (new file) 🆕
./bundle/core-VEUAOFMT.js 46.7 kB +46.7 kB (new file) 🆕
./bundle/devtoolsService-CMEQR2GQ.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/gemini-GUCIAGEO.js 553 kB +553 kB (new file) 🆕
./bundle/interactiveCli-6VO3EIFZ.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/oauth2-provider-V4YRHOB7.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-LV2OUWFA.js 1.97 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-HI6VSS7Q.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 4.97 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-CMNXJICE.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-DEYBHCHZ.js 932 B +932 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Apr 16, 2026
@gundermanc gundermanc enabled auto-merge April 16, 2026 23:35
@gundermanc gundermanc added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 22fb833 Apr 17, 2026
27 checks passed
@gundermanc gundermanc deleted the gundermanc/blank-line branch April 17, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants