Fall back when WebGL segmentation mask formats are unsupported#6297
Draft
bc-lee wants to merge 1 commit into
Draft
Fall back when WebGL segmentation mask formats are unsupported#6297bc-lee wants to merge 1 commit into
bc-lee wants to merge 1 commit into
Conversation
Some Android Chrome devices do not expose the WebGL float or half-float render target capabilities required by ImageSegmenter mask postprocessing. On those devices, the GL postprocessor currently fails inside graph execution and can leave the calculator with an empty mask vector, which then triggers a secondary mask-count RET_CHECK. Treat the missing GL mask format support as an unsupported capability instead of an internal invariant failure. Return FailedPrecondition from the GL postprocessor when neither the float32 path nor the half-float backup path is available, and let the segmentation calculator fall back to the existing CPU postprocessing path for that specific capability failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Android Chrome devices do not expose the WebGL float or half-float render target capabilities required by ImageSegmenter mask postprocessing. On those devices, the GL postprocessor currently fails inside graph execution and can leave the calculator with an empty mask vector, which then triggers a secondary mask-count
RET_CHECK.Treat the missing GL mask format support as an unsupported capability instead of an internal invariant failure. Return FailedPrecondition from the GL postprocessor when neither the float32 path nor the half-float backup path is available, and let the segmentation calculator fall back to the existing CPU postprocessing path for that specific capability failure.
Fixes #6296