fix(security): migrate docker/docker to moby/moby modules (BlackDuck Polaris findings)#1402
Open
fzl-22 wants to merge 4 commits into
Open
fix(security): migrate docker/docker to moby/moby modules (BlackDuck Polaris findings)#1402fzl-22 wants to merge 4 commits into
fzl-22 wants to merge 4 commits into
Conversation
added 4 commits
June 14, 2026 13:40
Author
|
@dhui @Fontinalis Could you review this when you get a chance? It addresses a high-severity SCA finding by migrating the docker/docker imports to moby/moby. All CI checks are passing. |
jhasrasuri
approved these changes
Jun 15, 2026
jhasrasuri
reviewed
Jun 15, 2026
Author
There was a problem hiding this comment.
@jhasrasuri Can you clarify what needs fixing in go.mod? Thanks
Author
|
Currently,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BlackDuck Polaris flagged
docker v28.3.3with 3 high-severity CVEs:Recommended target (long-term):
docker-v29.5.3(no known vulnerabilities).Changes
github.com/docker/dockeris deprecated since v29 ([1], [2]). This PRreplaces all direct imports with
github.com/moby/moby/clientandgithub.com/moby/moby/api, and adapts to the following v29 breaking changes:ContainerCreate,ContainerStart, etc. now use option structsclient.IsErrNotFoundremoved — replaced with error string checkPort.Int()replaced byPort.Num()(returnsuint16)PortBinding.HostIPchanged fromstringtonetip.AddrAdditionally:
-shortmode for images that were never pulled.
Limitation
docker/dockerremains as an indirect dependency viagithub.com/dhui/dktest,which has not migrated yet. Bumped to v28.5.2 to resolve a build error.
Full removal requires an upstream dktest update.
docker/dockerfrom the dependency tree.Related Links