Update aws go version to v2

[bkulkarni2]

No description provided.

[Copilot]

Pull request overview

This PR updates the project to Go 1.25 and migrates the S3 source driver to AWS SDK for Go v2, while also introducing a number of additional changes (CLI configuration via pflag/viper, dirty DB state handling with a migration cache directory, Docker packaging changes, and CI/test adjustments).

Changes:

• Migrate source/aws_s3 from AWS SDK v1 to AWS SDK v2 and add paginated listing support.
• Add “dirty-state handling” flow in migrate.Migrate with file-based last-success tracking, plus associated tests.
• Rework CLI/build/CI/container packaging (pflag/viper config, logrus, new install-to command, updated Dockerfiles/Makefile/workflows).

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
source/aws_s3/s3.go	Switch S3 driver implementation to AWS SDK v2 and add pagination for object listing.
source/aws_s3/s3_test.go	Update S3 fake client/tests for AWS SDK v2 interfaces/types.
README.md	Update supported Go versions badge.
migrate.go	Add dirty-state handling configuration and execution flow; add file copy/cleanup helpers.
migrate_test.go	Add tests for dirty-state handling helpers and config parsing.
Makefile	Change versioning and redefine build target to build a Docker image.
Jenkinsfile	Add Jenkins pipeline definition for building images (and currently commented unit tests).
internal/cli/main.go	Rework CLI argument/config handling to use pflag+viper; add install-to; add dirty-handling flags.
internal/cli/log.go	Switch CLI logging backend to logrus.
internal/cli/commands_install_to.go	Add install-to command implementation (copy running binary).
internal/cli/commands_install_to_test.go	Add unit/integration tests for install-to.
go.mod	Bump Go version to 1.25 and update dependencies (incl. AWS SDK v2, viper/pflag, logrus, multierror).
go.sum	Dependency checksum updates corresponding to go.mod changes.
Dockerfile.github-actions	Change base image to alpine:latest.
Dockerfile	Change build context path and switch runtime image to distroless; copy config into image.
docker-deploy.sh	Add --pull to docker build.
database/sqlserver/sqlserver_test.go	Unconditionally skip SQL Server tests.
cmd/migrate/main.go	Add viper/pflag + config loading setup and hotload driver registration.
cmd/migrate/config/defaults.yaml	Add default config file for the containerized CLI.
cmd/migrate/config.go	Define pflag flags for config-driven CLI.
cmd/migrate/.gitignore	Ignore built migrate binary under cmd/migrate.
cli/main.go	Keep deprecated wrapper main package.
.github/workflows/ci.yaml	Drop Go 1.24 from matrix, disable lint job, and adjust test DB tag set.

Comments suppressed due to low confidence (1)

cli/main.go:10

• internal/cli.Main now relies on pflag/viper being initialized (Parse, BindPFlags, config/env setup) before it runs. This deprecated wrapper binary calls cli.Main(Version) without that initialization, so flags/config won’t be read and command parsing may break for users still invoking the legacy cli entrypoint. Consider keeping the old flag-parsing path here or calling the same initialization used in cmd/migrate/main.go before invoking internal/cli.Main.

// Deprecated, please use cmd/migrate
func main() {
	cli.Main(Version)
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using alpine:latest makes builds non-reproducible and can unexpectedly pull in breaking changes or vulnerable images over time. Pin to a specific Alpine version (and ideally a digest) to keep CI builds deterministic.

Suggested change

	FROM alpine:latest
	FROM alpine:3.20

[Copilot]

version is overwritten from viper config (viper.GetString("version")), but --version historically behaved as a boolean flag (print version and exit). With the current logic, --version won’t work as intended and can even require a string argument. Consider restoring a boolean --version flag (or a separate --print-version) and don’t overwrite the passed-in version string that should be printed.

Suggested change

	version = viper.GetString("version")
	printVersion := viper.GetBool("version")
	_ = printVersion

[Copilot]

The version printing condition is inverted: if version == "" { fmt.Fprintln(os.Stderr, version); os.Exit(0) } prints an empty string and exits, while the non-empty version never prints. This should check the version flag (boolean) and print the actual version value.

Suggested change

	if version == "" {
	if version != "" {

[Copilot]

--version is declared as a string flag with default Version, which changes the CLI contract (it now expects an argument) and interacts badly with viper’s GetString("version") usage. To preserve standard CLI behavior, this should be a boolean flag (print version and exit), while the actual version value should remain the Version variable.

Suggested change

	flagVersion = pflag.String("version", Version, "Print version")
	flagVersion = pflag.Bool("version", false, "Print version")

[Copilot]

The unsupported-scheme error reports scheme (always "file") instead of the actual unsupported uri.Scheme, which makes debugging harder. Use the parsed scheme in the error message so callers can see what was rejected.

Suggested change

	return "", "", fmt.Errorf("unsupported scheme: %s", scheme)
	return "", "", fmt.Errorf("unsupported scheme: %s", uri.Scheme)

[Copilot]

The help text documents --database but the code reads database.dsn (and constructs a DSN from database.*). Either update the usage text to the actual flag name (--database.dsn) or add a compatibility --database flag that maps to the same config key.

Suggested change

	--database Run migrations against this database (driver://url)
	--database.dsn Run migrations against this database (driver://url)

[Copilot]

The defaults file keys/types don’t match what the CLI reads: the code uses viper.GetString("version") (string) and viper.GetInt("lock-timeout"), but this file sets version: false (bool) and lockTimeout (camelCase). As written, these defaults won’t apply—align the keys and keep version consistently typed.

Suggested change

	version: false
	verbose: true
	prefetch: 10
	lockTimeout: 15
	version: ""
	verbose: true
	prefetch: 10
	lock-timeout: 15

[Copilot]

When a migration Run fails, the code sets lastCleanMigrationApplied = migr.TargetVersion (when still 0) and persists it as “last successful”. For an up migration, TargetVersion is the new version that failed, so later dirty-state recovery can incorrectly mark an unapplied version as clean. Track the last clean DB version before setting dirty (e.g., initialize from curVersion and update only after successful SetVersion(..., false)).

[Copilot]

cleanupFiles calls source.Parse on every directory entry and returns an error for non-migration files. If destPath contains unrelated files (or a marker like lastSuccessfulMigration), cleanup will fail and block successful migrations. Filter using source.Regex (and/or explicitly skip lastSuccessfulMigrationFile) before parsing/removing.

[Copilot]

The PR title suggests only updating the AWS Go SDK to v2, but this diff also introduces substantial new behavior (dirty-state handling, CLI config via viper/pflag, Docker/CI changes, new install-to command). Consider updating the PR title/description to reflect the broader scope, or splitting into smaller PRs to reduce review and rollback risk.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

cli/main.go:10

• cli/main.go (deprecated entrypoint) calls internal/cli.Main directly, but the updated CLI now depends on pflag/Viper initialization done in cmd/migrate/main.go (binding flags, env, and optional config). Without similar initialization here, the deprecated binary will not parse flags/config correctly. Either keep the legacy CLI behavior or add the minimal init/setup here too.

import (
	"github.com/golang-migrate/migrate/v4/internal/cli"
)

// Deprecated, please use cmd/migrate
func main() {
	cli.Main(Version)
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In parsePath(), the returned error message always reports the hardcoded scheme value ("file") rather than the actual unsupported uri.Scheme. This will mislead users (e.g., s3:///... will error as "unsupported scheme: file"). Use uri.Scheme in the error and consider keeping the returned scheme consistent with the validated value.

Suggested change

	return "", "", fmt.Errorf("unsupported scheme: %s", scheme)
	return "", "", fmt.Errorf("unsupported scheme: %s", uri.Scheme)

[Copilot]

lastCleanMigrationApplied is initialized to 0 and, on the first migration failure, is set to migr.TargetVersion. That value represents the post-migration version, not the last successfully applied clean version, so the written lastSuccessfulMigration can be incorrect. Track the last clean version explicitly (e.g., initialize from m.databaseDrv.Version() before the loop and update it only after a successful SetVersion(..., false)), and avoid using 0 as a sentinel since version 0 can be valid.

[Copilot]

The version printing logic is inverted: if version == "" { fmt.Fprintln(...); os.Exit(0) } prints an empty string and exits when the version is empty, rather than when the user requested --version. This makes migrate --version ineffective and can cause silent exits if config coercion yields an empty string. Gate this on a dedicated boolean flag and print the actual build version string.

[Copilot]

The final image copies /etc/ssl/certs/ from the builder stage, but the builder image doesn’t install ca-certificates, so this directory may be empty and TLS connections can fail at runtime. Install ca-certificates in the builder (or add a separate certs stage) before copying, or use a distroless base variant that already includes certificates.

Suggested change

	RUN apk add --no-cache git gcc musl-dev make
	RUN apk add --no-cache git gcc musl-dev make ca-certificates

[Copilot]

In TestWithDirtyStateConfig, the assertion compares pointers (m.dirtyStateConf == tt.wantConf) and the condition is inverted, so the test doesn’t actually validate the produced config values. Use a field-by-field comparison (e.g., assert.Equal / reflect.DeepEqual) and fail when the config differs from wantConf.

[Copilot]

In the error-check branch, strings.Contains(err.Error(), test.err.Error()) will panic if test.err is nil (several test cases set err: nil). If handleDirtyState() unexpectedly returns an error in those cases, the test will crash rather than fail with a useful message. Guard against test.err == nil and use explicit expected-error assertions.

Suggested change

	if err = m.handleDirtyState(); err != nil {
	if strings.Contains(err.Error(), test.err.Error()) {
	t.Logf("expected error %v, got %v", test.err, err)
	if !test.setupFailure {
	if err = os.Remove(lastSuccessfulMigrationPath); err != nil {
	t.Fatal(err)
	}
	}
	return
	} else {
	t.Fatal(err)
	}
	}
	err = m.handleDirtyState()
	if test.err != nil {
	if err == nil {
	t.Fatalf("expected error %v, got nil", test.err)
	}
	if !strings.Contains(err.Error(), test.err.Error()) {
	t.Fatalf("expected error containing %q, got %v", test.err.Error(), err)
	}
	t.Logf("expected error %v, got %v", test.err, err)
	if !test.setupFailure {
	if err = os.Remove(lastSuccessfulMigrationPath); err != nil {
	t.Fatal(err)
	}
	}
	return
	}
	if err != nil {
	t.Fatalf("expected no error, got %v", err)
	}