Skip to content

fix(mysql): correct error message for x-statement-timeout parsing#1383

Open
zigzagdev wants to merge 1 commit into
golang-migrate:masterfrom
zigzagdev:fix/err-msg-type
Open

fix(mysql): correct error message for x-statement-timeout parsing#1383
zigzagdev wants to merge 1 commit into
golang-migrate:masterfrom
zigzagdev:fix/err-msg-type

Conversation

@zigzagdev

Copy link
Copy Markdown

Summary

Fix incorrect error message for x-statement-timeout parsing.

Problem

strconv.Atoi is used to parse x-statement-timeout, but the error message incorrectly referred to the value as float.

// Before
return nil, fmt.Errorf("could not parse x-statement-timeout as float: %w", err)

Fix

// After
return nil, fmt.Errorf("could not parse x-statement-timeout as integer: %w", err)

Notes

  • Logic is unchanged
  • No tests required as this is a string-only fix

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 54.432%. remained the same
when pulling 793308f on zigzagdev:fix/err-msg-type
into 2bd822b on golang-migrate:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants