Skip to content

Finding types in default namespaces#89

Open
dyron wants to merge 2 commits into
goetas-webservices:masterfrom
dyron:fix_elements_in_default_namespace
Open

Finding types in default namespaces#89
dyron wants to merge 2 commits into
goetas-webservices:masterfrom
dyron:fix_elements_in_default_namespace

Conversation

@dyron
Copy link
Copy Markdown

@dyron dyron commented Feb 23, 2025

While using https://github.com/goetas-webservices/xsd2php the OTA unit tests failed with messages like

[...]
25) GoetasWebservices\Xsd\XsdToPhp\Tests\JmsSerializer\OTA\OTASerializationTest::testConversion
GoetasWebservices\XML\XSDReader\Exception\TypeException: Can't find type named {}#NightDurationType, at line 191 in /var/www/html/xsd2php/tests/JmsSerializer/OTA/otaxml/OTA_SimpleTypes.xsd  in /var/www/html/xsd2php/vendor/goetas-webservices/xsd-reader/src/SchemaReader.php:1136

26) GoetasWebservices\Xsd\XsdToPhp\Tests\JmsSerializer\OTA\PHPConversionTest::testMultiplicity
GoetasWebservices\XML\XSDReader\Exception\TypeException: Can't find type named {}#ary, at line 6 in schema.xsd

27) GoetasWebservices\Xsd\XsdToPhp\Tests\JmsSerializer\OTA\PHPConversionTest::testNestedMultiplicity
GoetasWebservices\XML\XSDReader\Exception\TypeException: Can't find type named {}#ary, at line 5 in schema.xsd

28) GoetasWebservices\Xsd\XsdToPhp\Tests\JmsSerializer\OTA\PHPConversionTest::testMultipleArrayTypes
GoetasWebservices\XML\XSDReader\Exception\TypeException: Can't find type named {}#ArrayOfStrings, at line 13 in schema.xsd

@Guite
Copy link
Copy Markdown
Collaborator

Guite commented Feb 26, 2025

@dyron thank you very much for the fix

@goetas adding you as reviewer

@Guite Guite requested a review from goetas February 26, 2025 11:22
@goetas
Copy link
Copy Markdown
Member

goetas commented Mar 13, 2025

@dyron Could you please add a test for this usecse?

@dyron
Copy link
Copy Markdown
Author

dyron commented Mar 22, 2025

A test is added inspired by goetas-webservices/xsd2php#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants