Add timeout to token source subprocess calls#14
Merged
jgowdy-godaddy merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Credential helpers (1Password CLI, AWS Secrets Manager CLI, custom scripts via `token_source`) were invoked with `Command::output()` and no deadline. A wedged helper (stalled network, hung keychain prompt, broken shim) would block `npm install`/`npx` indefinitely with no signal to the user. Adopts `enclaveapp_core::timeout::run_with_timeout` with a 60s default, overridable via `NPMENC_TOKEN_SOURCE_TIMEOUT_SECS`. On timeout, the helper process is killed and a clear error is returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credential helpers configured via `token_source` (1Password CLI, AWS Secrets Manager, custom scripts) were invoked with `Command::output()` and no deadline. A wedged helper would block `npm install`/`npx` indefinitely with no signal to the user.
Adopts `enclaveapp_core::timeout::run_with_timeout` with a 60s default, overridable via `NPMENC_TOKEN_SOURCE_TIMEOUT_SECS`. On timeout the helper is killed and a clear error surfaces.
Dependency
Requires libenclaveapp#52 (the shared `enclaveapp_core::timeout` module).
Test plan