Skip to content

apple: silent empty-password unlock of login keychain on open #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgowdy-godaddy merged 1 commit into from
Apr 17, 2026
Merged

apple: silent empty-password unlock of login keychain on open #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion crates/enclaveapp-apple/swift/bridge.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,22 @@ private func openLoginKeychain() -> SecKeychain? {
]
for path in candidates {
var kc: SecKeychain?
if SecKeychainOpen(path, &kc) == errSecSuccess, kc != nil {
if SecKeychainOpen(path, &kc) == errSecSuccess, let kc = kc {
// Best-effort silent unlock with an empty password.
//
// On interactive dev sessions the keychain is already
// unlocked and this is a no-op. On CI runners (GitHub
// Actions `macos-latest`) the login keychain is created
// at image-provision time with an empty password and
// re-locks between jobs, so without this call the next
// `SecItemAdd` blocks indefinitely waiting for a user
// to type the unlock password into a GUI prompt that
// never comes. `usePassword: true` + zero-length
// password avoids the prompt entirely; if the keychain
// has a real password the unlock fails here and the
// subsequent op surfaces the real error — we don't
// mask it with a fallback.
_ = SecKeychainUnlock(kc, 0, nil, true)
return kc
}
}
Expand Down