Correct Okta-session-reuse claim; expand threat model#28
Merged
jgowdy-godaddy merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
THREAT_MODEL.md T11 previously claimed transparent Okta session reuse was disabled. It is actively implemented: awsenc caches the Okta /authn session token as ECIES ciphertext in the .enc file (FLAG_HAS_OKTA_SESSION), and awsenc serve's try_transparent_reauth path decrypts it to silently refresh expiring AWS creds for the remainder of Okta's session lifetime. Rewritten to describe the real behavior and its trust model. DESIGN.md "Okta Session Reuse Status" rewritten for the same reason. New threats added: - T12 SAML / STS parser hardening (scraper + roxmltree, chunked-TE cap) - T13 HTTP response size limits (256 KB, both Content-Length and streaming) - T14 local config.toml tamper redirecting Okta auth - T15 concurrent serve race (duplicate STS, atomic-write resolves) - T16 cache rollback — bounded by server-side STS Expiration - T17 binary discovery / PATH hijack (currently no $BROWSER/gh surface) - T18 Type 1 trusted-consumer boundary (explicit accepted risk)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The headline fix: `THREAT_MODEL.md` T11 and `DESIGN.md` §Okta Session Reuse Status both previously claimed that transparent Okta session reuse was disabled. It is actively implemented. After a successful `awsenc auth`, the Okta `/authn` session token is cached as ECIES ciphertext alongside the AWS credentials (cache flag `FLAG_HAS_OKTA_SESSION`), and `awsenc serve` calls `try_transparent_reauth` to refresh expiring AWS creds silently — without prompting for MFA — for the lifetime of Okta's session.
This PR rewrites both sections to describe the real behavior and its trust model, then expands the threat inventory with seven new entries discovered during the same audit pass:
Test plan