Add DNS provider for Com Laude#2886
Conversation
|
Thank you for your patience to review the request, unfortunately, I do not have direct access to the privilege information required to run the commands. |
|
OK, but why have you asked for the addition of this provider? 🤔 Perhaps you could ask someone to test the PR? |
b63378b to
c4ab057
Compare
|
Thank you for waiting. This is the information shared by end user, hope it helps. Test result (Windows 11 / Git Bash) Result: ACME order starts, but DNS provider fails during Com Laude login JSON parsing. Sanitized response shape from Com Laude: {
"errors": [],
"messages": [
{
"code": "correct_login_details",
"message": "Log-in details correct"
}
],
"data": {
"token_type": "Bearer",
"expires_in": 7200,
"access_token": "<redacted>",
"refresh_token": "<redacted>",
"dnsdashboard_link": 1
},
"status_code": 200
}It looks like data is an object, but the code expects []TokenInfo. Suggest changing LoginResponse.data to a single object (or supporting both object/array). |
|
This means that the API documentation is wrong. https://api.comlaude.com/docs#/Auth/POST.api_login {
"errors": [
"string"
],
"messages": [
{
"code": "correct_login_details",
"message": "Log-in details correct"
}
],
"data": [
{
"token_type": "Bearer",
"expires_in": 7600,
"access_token": "",
"refresh_token": "",
"dnsdashboard_link": 1
}
],
"status_code": 200
} |
|
I updated the PR, can you pull, build, and run again? |
Closes #2880
Ping @lackern-se-digicert, can you run the command with your domain, credentials, etc. (and put the output of this command to a comment)?
Note that the wildcard domain is important.
How to test this PR?
git clone https://github.com/ldez/lego.git cd lego git checkout feat/dns/comlaudemake:make buildmake:go build -o dist/lego ./cmd/lego