Add DNS provider for Combell (reseller only)#1581
Open
ldez wants to merge 2 commits intogo-acme:masterfrom
Open
Add DNS provider for Combell (reseller only)#1581ldez wants to merge 2 commits intogo-acme:masterfrom
ldez wants to merge 2 commits intogo-acme:masterfrom
Conversation
|
blush ... now it turns out, that the combell API is only for resellers, not for 'ordinary' customers. |
Member
Author
|
Hello @jwaes, it seems like Combell has another API, related to OpenStack, if it's true maybe you can use Designate DNSaaS for Openstack. |
guoard
reviewed
Oct 24, 2022
guoard
reviewed
Oct 24, 2022
b423630 to
3416a6f
Compare
49facb0 to
b397084
Compare
b63378b to
c4ab057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1573
@jwaes can you run the command with your domain, email, credentials, etc. (and put the output of this command to a comment)?
Note that the wildcard domain is important.
How to test this PR?
git clone https://github.com/ldez/lego.git cd lego git checkout ldez:feat/combellmake:make buildmake:go build -o dist/lego ./cmd/lego