Update BrowserService javadoc#452
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the iOS web-authentication documentation for BrowserService.launchWebAuthentication and adds an early-escape guard in the iOS native implementation when the authentication URL is invalid.
Changes:
- Expanded
BrowserServiceJavadoc to document iOS 17.4+ HTTPS callback requirements and configuration steps. - Added an iOS native
NSURLnil-check to fail fast and return a null authentication result when the auth URL can’t be parsed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
modules/browser/src/main/native/ios/Browser.m |
Adds validation for invalid auth URLs before starting ASWebAuthenticationSession. |
modules/browser/src/main/java/com/gluonhq/attach/browser/BrowserService.java |
Updates Javadoc for iOS HTTPS callback setup and clarifies iOS configuration requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+142
to
+146
| if (nsUrl == nil) { | ||
| AttachLog(@"Invalid authentication URL: %@", url); | ||
| sendAuthResult(nil); | ||
| return; | ||
| } |
Comment on lines
+143
to
+145
| AttachLog(@"Invalid authentication URL: %@", url); | ||
| sendAuthResult(nil); | ||
| return; |
Comment on lines
+142
to
+146
| if (nsUrl == nil) { | ||
| AttachLog(@"Invalid authentication URL: %@", url); | ||
| sendAuthResult(nil); | ||
| return; | ||
| } |
Comment on lines
+124
to
+126
| * <p><b>iOS Configuration</b>: none for the custom-scheme form; the HTTPS form requires the | ||
| * Associated Domains capability and {@code webcredentials} entitlement described above.</p> | ||
| * |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.