Fix video setPosition call on Android

[jperedadnr]

Fixes #446

[Copilot]

Pull request overview

Fixes the Android JNI bridge for AndroidVideoService.setPosition(...) by invoking the correct Dalvik method ID, resolving the reported JNI “bad arguments” crash (Issue #446).

Changes:

• Switch Java_com_gluonhq_attach_video_impl_AndroidVideoService_setPosition to call jVideoPositionMethod instead of jVideoPlaylistMethod.
• Update the file header copyright year.

Comments suppressed due to low confidence (1)

modules/video/src/main/native/android/c/video.c:217

• GetStringUTFChars results for jalignmentH / jalignmentV are never released (the ReleaseStringUTFChars calls are commented out), which can leak/pin memory across repeated setPosition calls. Also, the dalignmentH / dalignmentV local refs created on the Dalvik env should be deleted before detaching to avoid growing the local-ref table if the thread stays attached.

    const char *alignmentHChars = (*env)->GetStringUTFChars(env, jalignmentH, NULL);
    const char *alignmentVChars = (*env)->GetStringUTFChars(env, jalignmentV, NULL);
    if (isDebugAttach()) {
        ATTACH_LOG_FINE("Video Alignment H: %s, V: %s", alignmentHChars, alignmentVChars);
    }
    ATTACH_DALVIK();
    jstring dalignmentH = (*dalvikEnv)->NewStringUTF(dalvikEnv, alignmentHChars);
    jstring dalignmentV = (*dalvikEnv)->NewStringUTF(dalvikEnv, alignmentVChars);
    (*dalvikEnv)->CallVoidMethod(dalvikEnv, jDalvikVideoService, jVideoPositionMethod,
                   dalignmentH, dalignmentV, jtopPadding, jrightPadding, jbottomPadding, jleftPadding);
    DETACH_DALVIK();
    // (*env)->ReleaseStringUTFChars(env, jalignmentH, alignmentHChars);
    // (*env)->ReleaseStringUTFChars(env, jalignmentV, alignmentVChars);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.