Skip to content

Rework permission UI#23959

Open
AdrienClairembault wants to merge 7 commits intoglpi-project:mainfrom
AdrienClairembault:rework-permission-ui
Open

Rework permission UI#23959
AdrienClairembault wants to merge 7 commits intoglpi-project:mainfrom
AdrienClairembault:rework-permission-ui

Conversation

@AdrienClairembault
Copy link
Copy Markdown
Member

@AdrienClairembault AdrienClairembault commented Apr 17, 2026

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.

Description

Before;

image

After:
image

The display is more compact and try to avoid unnecessary informations compared to the previous iteration.
The form is cleaned up as the dropdown were a bit out of place.

One of the main goal was to hide the extra entities id / is recursive options which are not often used and create confusion for the users (we can't drop them because they are still used by few).

They are hidden by default:

image

And can be toggled with a button:

image

When the list is empty, we have a specific message:

image

@AdrienClairembault AdrienClairembault linked an issue Apr 17, 2026 that may be closed by this pull request
@AdrienClairembault AdrienClairembault force-pushed the rework-permission-ui branch 5 times, most recently from 9994903 to 0c6aac3 Compare April 20, 2026 14:43
Comment thread ajax/subvisibility.php
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this file should be replaced by proper controllers + templates.
I've added it to the backlog so it can be done separately.

Comment thread ajax/visibility.php
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this file should be replaced by proper controllers + templates.
I've added it to the backlog so it can be done separately.

@AdrienClairembault AdrienClairembault marked this pull request as ready for review April 21, 2026 11:59
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread templates/pages/tools/kb/modal/permissions.html.twig
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread css/includes/components/_kb.scss Outdated
@cconard96
Copy link
Copy Markdown
Contributor

Additional review from functional testing:

Avoid reloading entire page every time user wants to add visibility targets; it is very annoying. It doesn't reload the page when targets are removed.

@AdrienClairembault
Copy link
Copy Markdown
Member Author

AdrienClairembault commented Apr 21, 2026

Avoid reloading entire page every time user wants to add visibility targets; it is very annoying. It doesn't reload the page when targets are removed.

I agree but I wanted to keep changes low here as there are already a lot of lines changed.
It is planned as a dedicated task in the backlog: https://github.com/orgs/glpi-project/projects/26/views/1?groupedBy%5BcolumnId%5D=247277380&pane=issue&itemId=175839857.

@AdrienClairembault
Copy link
Copy Markdown
Member Author

Rebased for conflicts, there was no others changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve permissions UI

2 participants