Rework permission UI#23959
Conversation
9994903 to
0c6aac3
Compare
There was a problem hiding this comment.
Note: this file should be replaced by proper controllers + templates.
I've added it to the backlog so it can be done separately.
There was a problem hiding this comment.
Note: this file should be replaced by proper controllers + templates.
I've added it to the backlog so it can be done separately.
0c6aac3 to
2e6adc4
Compare
|
Additional review from functional testing: Avoid reloading entire page every time user wants to add visibility targets; it is very annoying. It doesn't reload the page when targets are removed. |
I agree but I wanted to keep changes low here as there are already a lot of lines changed. |
778db7f to
d5c97e2
Compare
|
Rebased for conflicts, there was no others changes. |
Checklist before requesting a review
Description
Before;
After:

The display is more compact and try to avoid unnecessary informations compared to the previous iteration.
The form is cleaned up as the dropdown were a bit out of place.
One of the main goal was to hide the extra entities id / is recursive options which are not often used and create confusion for the users (we can't drop them because they are still used by few).
They are hidden by default:
And can be toggled with a button:
When the list is empty, we have a specific message: