Skip to content

Add/project task assigne in task team#23945

Merged
cedric-anne merged 2 commits intoglpi-project:11.0/bugfixesfrom
Herafia:add/project-task-assigne-in-task-team
Apr 30, 2026
Merged

Add/project task assigne in task team#23945
cedric-anne merged 2 commits intoglpi-project:11.0/bugfixesfrom
Herafia:add/project-task-assigne-in-task-team

Conversation

@Herafia
Copy link
Copy Markdown
Contributor

@Herafia Herafia commented Apr 16, 2026

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !43335
  • Adding bulk actions for project task teams
    Allows you to add users, groups, supplier, and contacts to the team of multiple tasks using “Edit” bulk actions.

@Herafia Herafia self-assigned this Apr 16, 2026
@Herafia Herafia requested review from Rom1-B and stonebuzz April 16, 2026 15:26
Comment thread src/ProjectTask.php Outdated
@Herafia Herafia requested a review from Rom1-B April 20, 2026 14:51
Comment thread tests/functional/ProjectTaskTest.php Outdated
Copy link
Copy Markdown
Contributor

@stonebuzz stonebuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fonctionnaly OK for me

Comment thread tests/functional/ProjectTaskTest.php Outdated
Copy link
Copy Markdown
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to fix conflicts.
Also, please squash your commits, and use a proper commit message.

Please remember commits messages must be in english, and descriptive.
Of course everyone will use some "fix" commits (or even "fixup! fixup! fixup! fixup! fixup! fixup!" ;p).

When squashing+merge on GH web UI, commit will take PR title, and description of all commits. Most of the time (90%) I cannot rework commit messages - and that's anyway more work re rephrase.

Copy link
Copy Markdown
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour does not seems expected, and it makes the code pretty hard to understand, and therefore to maintain.
I think it would be preferable to override the processMassiveActionsForOneItemtype() method to handle this behaviour only in the massive actions context.

@Herafia Herafia force-pushed the add/project-task-assigne-in-task-team branch from 3405ab5 to 99cab04 Compare April 29, 2026 14:58
@cedric-anne cedric-anne dismissed trasher’s stale review April 30, 2026 09:55

changes were made

@cedric-anne cedric-anne merged commit 61a06e2 into glpi-project:11.0/bugfixes Apr 30, 2026
12 checks passed
@cedric-anne cedric-anne added this to the 11.0.8 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants