Add/project task assigne in task team#23945
Add/project task assigne in task team#23945cedric-anne merged 2 commits intoglpi-project:11.0/bugfixesfrom
Conversation
stonebuzz
left a comment
There was a problem hiding this comment.
fonctionnaly OK for me
trasher
left a comment
There was a problem hiding this comment.
Please rebase to fix conflicts.
Also, please squash your commits, and use a proper commit message.
Please remember commits messages must be in english, and descriptive.
Of course everyone will use some "fix" commits (or even "fixup! fixup! fixup! fixup! fixup! fixup!" ;p).
When squashing+merge on GH web UI, commit will take PR title, and description of all commits. Most of the time (90%) I cannot rework commit messages - and that's anyway more work re rephrase.
cedric-anne
left a comment
There was a problem hiding this comment.
This behaviour does not seems expected, and it makes the code pretty hard to understand, and therefore to maintain.
I think it would be preferable to override the processMassiveActionsForOneItemtype() method to handle this behaviour only in the massive actions context.
3405ab5 to
99cab04
Compare
Checklist before requesting a review
Please delete options that are not relevant.
Description
Allows you to add users, groups, supplier, and contacts to the team of multiple tasks using “Edit” bulk actions.