Skip to content

KB : add tests e2e for permissions (targets)#23942

Open
f2cmb wants to merge 3 commits intoglpi-project:mainfrom
f2cmb:kb/permissions/tests
Open

KB : add tests e2e for permissions (targets)#23942
f2cmb wants to merge 3 commits intoglpi-project:mainfrom
f2cmb:kb/permissions/tests

Conversation

@f2cmb
Copy link
Copy Markdown
Contributor

@f2cmb f2cmb commented Apr 16, 2026

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

@f2cmb f2cmb linked an issue Apr 16, 2026 that may be closed by this pull request
Comment thread templates/pages/tools/kb/modal/permissions.html.twig Outdated
Comment thread tests/e2e/specs/Knowbase/permissions.spec.ts Outdated
@f2cmb f2cmb marked this pull request as ready for review April 16, 2026 14:32
@f2cmb
Copy link
Copy Markdown
Contributor Author

f2cmb commented Apr 20, 2026

So i reworked the whole proposal : tried to stick more to Playwright best practices, with using better targetings, whichs leads also to a few changes in the templates and better accessibility for some.

Comment thread templates/pages/tools/kb/modal/permissions.html.twig
Comment thread templates/pages/tools/kb/modal/permissions.html.twig
Comment thread templates/pages/tools/kb/modal/permissions.html.twig
@f2cmb f2cmb force-pushed the kb/permissions/tests branch from d8b537d to 54cd6a8 Compare April 20, 2026 14:29
Copy link
Copy Markdown
Member

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said IRL you should probably wait for #23942 as it changes the UI elements quite a lot.

@f2cmb f2cmb changed the title add tests e2e for permissions (targets) KB : add tests e2e for permissions (targets) Apr 28, 2026
@cedric-anne
Copy link
Copy Markdown
Member

As said IRL you should probably wait for #23942 as it changes the UI elements quite a lot.

The mentioned PR is the current PR. What was the PR you wanted to mention ?

@AdrienClairembault
Copy link
Copy Markdown
Member

Indeed, I meant #23959.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tests for permissions

5 participants