Skip to content

fix(service_catalog): limit card height in service catalog #23880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MyvTsv wants to merge 2 commits into
base: 11.0/bugfixes
Choose a base branch
from
+4 −3
Open

fix(service_catalog): limit card height in service catalog #23880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012ce41
fix(service_catalog): limit card height in service catalog
MyvTsv Apr 15, 2026
829ca6c
fix
MyvTsv Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/components/helpdesk_forms/service_catalog_item.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@
{% endif %}
</div>
<div
class="text-secondary remove-last-tinymce-margin"
class="text-secondary remove-last-tinymce-margin overflow-hidden"
style="max-height: 300px"
Comment on lines +69 to +70
Copy link
Copy Markdown
Contributor

@Rom1-B Rom1-B Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 300px still too much? (based on your screenshot examples)

Additionally, the full description can be displayed when you hover over it with the mouse?

Copy link
Copy Markdown
Contributor Author

@MyvTsv MyvTsv Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reduce the pixel size. However, I don't think displaying all the text is a good idea in terms of usability when the user hovers over a map, because the interface would flicker a lot.

data-testid="service-catalog-description"
>
{{ item.getServiceCatalogItemDescription()|safe_html }}
Expand Down
2 changes: 1 addition & 1 deletion templates/components/helpdesk_forms/service_catalog_items.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<h2 id="{{ unique_dom_id }}" class="mb-0 fs-2">
{{ item.getServiceCatalogItemTitle() }}
</h2>
<div class="card-subtitle ms-2 remove-last-tinymce-margin">
<div class="card-subtitle ms-2 remove-last-tinymce-margin overflow-hidden" style="max-height: 300px">
{{ item.getServiceCatalogItemDescription()|safe_html }}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/helpdesk_forms/service_catalog_nested_item.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
>
{{ child.getServiceCatalogItemTitle() }}
</h2>
<div class="text-secondary remove-last-tinymce-margin">
<div class="text-secondary remove-last-tinymce-margin overflow-hidden" style="max-height: 300px">
{{ child.getServiceCatalogItemDescription()|safe_html }}
</div>
</div>
Expand Down