Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

Add failing test for invalid attribute name#1765

Open
ef4 wants to merge 1 commit intomainfrom
invalid-attribute-name
Open

Add failing test for invalid attribute name#1765
ef4 wants to merge 1 commit intomainfrom
invalid-attribute-name

Conversation

@ef4
Copy link
Copy Markdown
Contributor

@ef4 ef4 commented Aug 1, 2025

If you leave a stray character inside element space, glimmer will compile it as an HTML attribute and attempt to setAttribute at runtime, which the browser will reject. This is very confusing to debug. It should probably be a direct compile error instead.

If you leave a stray character inside element space, glimmer will compile it as an HTM attribute and attempt to setAttribute at runtime, which the browser will reject. This is very confusing to debug. It should probably be a direct compile error instead.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 1, 2025

This PRmain
Dev
600K └─┬ .
169K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 36K   ├── validator
 27K   ├── manager
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
600K └─┬ .
169K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 36K   ├── validator
 27K   ├── manager
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
Prod
236K └─┬ .
 70K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
9.8K   ├── validator
7.9K   ├── manager
4.8K   ├── program
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner
236K └─┬ .
 70K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
9.8K   ├── validator
7.9K   ├── manager
4.8K   ├── program
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant