Repository navigation
feat: add NDJSON file sink - #29
Merged
Merged
Conversation
Adds NDJSONSink that writes generated events as newline-delimited JSON (one record per line), preserving nested structures without flattening. - glassgen/sinks/ndjson_sink.py: new sink implementation - glassgen/sinks/__init__.py: register "ndjson" in SinkFactory - tests/test_sinks.py: tests for publish, bulk publish, nested structure - tests/conftest.py: temp_ndjson_file fixture - docs/app/sinks/ndjson/page.mdx: sink documentation page - docs/app/sinks/page.mdx: add NDJSON to available sinks list Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Test Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Test Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ashish-bagri
approved these changes
Mar 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NDJSONSinkthat writes generated events as newline-delimited JSON (one record per line)"ndjson"inSinkFactory— usable via"type": "ndjson"in configUsage
{ "sink": { "type": "ndjson", "params": { "path": "output.ndjson" } } }Test plan
test_ndjson_sink_publish— single record written as one JSON linetest_ndjson_sink_bulk_publish— multiple records each on their own linetest_ndjson_sink_preserves_nested_structure— nested objects and arrays are not flattenedtest_sink_factory—SinkFactory.create("ndjson", ...)returnsNDJSONSink🤖 Generated with Claude Code