Repository navigation
Minor fix for disabling duplication - #25
Merged
PabloPardoGarcia merged 3 commits intoMar 27, 2026
Merged
Conversation
Do not initialise DuplicateController when duplication.enabled is False. Previously the controller was created whenever a duplication config block was present, regardless of the enabled flag, causing duplicates to be generated even when the feature was turned off. Also adds TestGenerator covering both the disabled and enabled paths, with corrected test names and generate_optimized() called in the enabled-path test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Test Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuplicateControllerbeing initialised whenduplication.enabledisFalse— duplicates were generated even when the feature was turned offTestGeneratorwith two tests covering the disabled and enabled pathsgenerate_optimized()is correctly called in the enabled-path testCloses #21 (supersedes the original PR by @aditypan , which was accidentally closed during a merge conflict resolution).
And fixes #19
Test plan
test_duplicate_controller_is_none_when_duplication_disabled— assertsduplicate_controller is Nonewhenenabled=Falseand verifiesgenerate_simpleproduces correct batchestest_duplicate_controller_initialized_when_duplication_enabled— assertsduplicate_controller is not Nonewhenenabled=Trueand verifiesgenerate_optimizedproduces correct batches🤖 Generated with Claude Code