Repository navigation
Array generator enhancements - #22
Conversation
…ig is set to false" This reverts commit 64770f3.
|
@aditypan is attempting to deploy a commit to the GlassFlow Team on Vercel. A member of the Team first needs to authorize it. |
PabloPardoGarcia
left a comment
There was a problem hiding this comment.
Thanks for the contribution @aditypan !!
The fix is correct and the regex approach is a clear improvement over the old comma-split. The recursive reuse of _schema_dict_to_fields to parse nested generator params is elegant. However, the change silently breaks existing configurations that use the old flat syntax, and the test suite removes coverage for that syntax without replacement. These need to be addressed before merging.
|
@aditypan could you fix the format issues flagged by the failing test? Once that green I will merge the PR, thank you! |
|
@PabloPardoGarcia I have fixed the Format Issues. |
Test Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Enhanced the array generator to support data generation using other existing generators without failures. I used regex-based parsing to extract the parameter name, additional parameters, and count from expressions like "choice(red,blue,green), 2".
Previously, the array generator was expected to be used in the following format:
However, the earlier implementation would fail for cases like the price generator shown above. The implementation has now been enhanced to correctly handle such edge cases.
Current Array generator format updated to:
Fixes : #20