Repository navigation
Conversation
The pre-install/pre-upgrade hook was unconditionally generating a new UUID on every helm upgrade, overwriting the existing installation ID in the secret and sending a spurious helm_install event. The fix reads the existing secret upfront so the ID is reused on upgrades and only generated fresh on first install.
sudopower
changed the base branch from
main
to
kiran/etl-782-introduce-pg-bouncer-in-helm-chart
April 7, 2026 08:45
sudopower
changed the base branch from
kiran/etl-782-introduce-pg-bouncer-in-helm-chart
to
sudopower/pg-bouncer-chart
April 7, 2026 09:22
ashish-bagri
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
pre-install,pre-upgradehook was unconditionally callinguuidgenon everyhelm upgrade, causing two bugs:installation_idin the secret, breaking continuity across upgradeshelm_installevent fired on every upgrade (in addition to the correcthelm_upgradeevent frompost-upgrade.yaml)Fix
Move the existing secret lookup to the top of the hook script (before ID resolution), so:
installation_idglobal.usageStats.installationIdis set in values: always use that (unchanged behaviour)The secret lookup was already happening later in the script for the POST vs PATCH decision; this change hoists it up and removes the duplicate fetch.