Skip to content

Resolve several major issues: Vertical Metrics, Monospace Recognition #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottta wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Resolve several major issues: Vertical Metrics, Monospace Recognition #227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8394262
Avoid write lastChange and displayString to version control
ottta May 26, 2024
972eb52
Check `Use Typo Metrics` to get more consistent vertical metrics
ottta May 26, 2024
7da07ce
Change win metrics to avoid clipping
ottta May 26, 2024
d68bcf3
Resolve #21 #37 #169
ottta May 26, 2024
753e4aa
Resolve #111 not recognized as monospace font
ottta May 26, 2024
424fe7c
Export to `.ttf` (Glyphsapp export)
ottta May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sources/Monaspace Argon Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:29:24 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Argon.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:29:24 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Krypton Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:38:42 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Krypton.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:38:42 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Neon Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:45:34 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Neon.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:45:34 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Radon Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:50:54 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Radon.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 17:50:54 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Xenon Var.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;

@Finii Finii Jun 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be automatically set if it would be valid iirc.

Forcing the value to 1 while the font is not isFixedPitch can lead to problems, see for example google/fonts#225

Anyhow, the root cause should be in

and supposedly it is fixed now. But it is not. I can redo the search for offending glyphs if need be.

Here the isFixedPitch value in the font file:

fini@Air ~ % showttf ~/Downloads/monaspace-v1.101/fonts/otf/MonaspaceArgon-Regular.otf | tail -n +1065 | head
Required tables: glyf and loca have been replaced by CFF => OpenType
post table (at 7312)
	 format=00030000
	 italicAngle=0
	 underlinePos=-70
	 underlineWidth=72
	 fixedpitch=0
	 mem1=0
	 mem2=0
	 mem3=0
	 mem4=0
fini@Air ~ %

Here a screenshot of the "warning" to set it in Glyphs ;-)

Screenshot 2024-06-07 at 17 13 21

value = 1;
}
);
date = "2024-05-08 18:00:38 +0000";
Expand Down
4 changes: 4 additions & 0 deletions sources/Monaspace Xenon.glyphs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ value = 0;
{
name = "Use Typo Metrics";
value = 1;
},
{
name = isFixedPitch;
value = 1;
}
);
date = "2024-05-08 18:00:38 +0000";
Expand Down