fix(api-proxy): address review comments on OpenCode port 10004 routing by Copilot · Pull Request #1984 · github/gh-aw-firewall

Copilot · 2026-04-15T03:01:02Z

Addresses all review comments from the PR #1979 review thread: missing rate limiting on port 10004, inaccurate credential docs referencing an internal token, no .lock.yml for the new smoke workflow, and no test coverage for OpenCode routing.

Changes

src/types.ts: Corrected JSDoc credential priority to reference user-configurable vars COPILOT_GITHUB_TOKEN/COPILOT_API_KEY instead of the internal derived COPILOT_AUTH_TOKEN
.github/workflows/smoke-opencode.md: Added explicit note that this workflow has no compiled .lock.yml and is inactive in GitHub Actions; includes instructions for compiling once the opencode engine is supported
containers/api-proxy/server.js:
- Added checkRateLimit() to OpenCode HTTP handler (was the only proxy port missing it)
- Extracted resolveOpenCodeRoute() helper to centralize credential priority and return a needsAnthropicVersion flag, eliminating duplicated header injection logic across HTTP and WebSocket handlers
- Used resolveOpenCodeRoute() for startup guard — removes the duplicated OPENAI_API_KEY || ANTHROPIC_API_KEY || COPILOT_AUTH_TOKEN check
- Returns 503 with JSON error body (HTTP) or closes socket with 503 (WebSocket) when no credentials resolve, instead of silently returning
containers/api-proxy/server.test.js: Added 8 unit tests for resolveOpenCodeRoute() covering all three credential priority branches, mutual exclusivity of auth headers, needsAnthropicVersion flag, and null return when no credentials are set

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

- types.ts: correct credential priority comment to reference user-configurable vars COPILOT_GITHUB_TOKEN/COPILOT_API_KEY instead of internal COPILOT_AUTH_TOKEN - smoke-opencode.md: add note that lock file compilation is pending until opencode engine support lands in gh-aw - server.js: add rate limiting to OpenCode (port 10004) HTTP handler using content-length-aware checkRateLimit() call - server.js: extract resolveOpenCodeRoute() helper for testability and refactor handler to use it - server.test.js: add 8 unit tests covering all OpenCode routing priority scenarios and header injection Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/a0621fda-d1a3-449b-a3da-a9d0331c4c76

Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/a0621fda-d1a3-449b-a3da-a9d0331c4c76

- Add needsAnthropicVersion flag to resolveOpenCodeRoute return value to centralize anthropic-version header logic - Use resolveOpenCodeRoute() for startup guard instead of repeating the credential availability check - Update tests to assert needsAnthropicVersion for all scenarios Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/a0621fda-d1a3-449b-a3da-a9d0331c4c76

Copilot

Pull request overview

This PR updates the API proxy’s OpenCode (port 10004) routing to address prior review feedback, aligning credential selection, enforcing rate limiting, improving failure behavior, and adding unit coverage.

Changes:

Updates OpenCode port documentation to reflect the intended credential priority and default routing behavior.
Adds rate limiting to the OpenCode HTTP handler and centralizes routing/credential header selection via resolveOpenCodeRoute() for both HTTP and WebSocket paths.
Adds unit tests for resolveOpenCodeRoute() and introduces an (explicitly inactive) smoke workflow definition for OpenCode.

Show a summary per file

File	Description
`src/types.ts`	Updates JSDoc to reflect correct OpenCode routing defaults and credential priority.
`containers/api-proxy/server.js`	Adds OpenCode rate limiting, centralizes routing logic, and returns explicit 503 errors when credentials are unavailable.
`containers/api-proxy/server.test.js`	Adds unit tests covering OpenCode route resolution and header exclusivity behavior.
`.github/workflows/smoke-opencode.md`	Adds an OpenCode smoke workflow definition with a note that it’s not compiled/active yet.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 4/4 changed files
Comments generated: 2

containers/api-proxy/server.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-04-15T04:12:19Z

Smoke Test Results

✅ GitHub MCP: #1978 "fix: add size-based filtering to --env-all to prevent E2BIG", #1977 "fix: recover toolchain env vars from $GITHUB_ENV file"
✅ Playwright: github.com title contains "GitHub"
✅ File write: /tmp/gh-aw/agent/smoke-test-claude-24435902136.txt created
✅ Bash verify: file content confirmed

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-04-15T04:12:33Z

🔥 Smoke Test Results

Test	Status
GitHub MCP (list merged PRs → "fix: add size-based filtering..." #1978)	✅
GitHub.com connectivity	✅
File write/read	✅

Overall: PASS

PR: fix(api-proxy): address review comments on OpenCode port 10004 routing
Author: @app/copilot-swe-agent · Assignees: @lpcox @Copilot

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-04-15T04:12:43Z

Smoke test matrix:

GitHub MCP (last 2 merged PRs): ✅ fix: add size-based filtering to --env-all to prevent E2BIG; fix: recover toolchain env vars from $GITHUB_ENV file
Safe Inputs GH CLI (pr list --limit 2): ❌ tool safeinputs-gh unavailable
Playwright (github.com title contains GitHub): ✅
Tavily search (GitHub Agentic Workflows Firewall): ❌ Tavily tool unavailable
File write + bash cat (/tmp/gh-aw/agent/smoke-test-codex-24435902166.txt): ✅
Discussion oracle comment: ❌ github-discussion-query unavailable
Build (npm ci && npm run build): ✅
Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-04-15T04:13:39Z

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis `PING` (host.docker.internal:6379)	✅ `+PONG`
`pg_isready` (host.docker.internal:5432)	✅ accepting connections
`psql SELECT 1` (smoketest DB, postgres user)	✅ returned `1`

All checks passed. (redis-cli was not pre-installed; Redis was verified via raw TCP with nc.)

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-04-15T04:13:40Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.14.1	v20.20.2	❌
Go	go1.22.12	go1.22.12	✅

Result: Not all tests passed — Python and Node.js versions differ between host and chroot. The smoke-chroot label was not applied.

Tested by Smoke Chroot

github-actions · 2026-04-15T04:15:19Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	ok	✅ PASS
Go	env	✅	ok	✅ PASS
Go	uuid	✅	ok	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #1984 · ● 635.1K · ◷

Initial plan

b0c4a73

Copilot AI assigned Copilot and lpcox Apr 15, 2026

Copilot started work on behalf of lpcox April 15, 2026 03:01 View session

Copilot AI and others added 5 commits April 15, 2026 03:02

fix: update OpenCode proxy to default to Copilot/OpenAI routing

24e4cae

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

fix: address code review - correct comment to use COPILOT_AUTH_TOKEN

7c27652

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

fix: handle null route with 503 response in OpenCode proxy handlers

46217c1

Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/a0621fda-d1a3-449b-a3da-a9d0331c4c76

Copilot AI changed the title ~~[WIP] Fix code based on review comments~~ fix(api-proxy): address review comments on OpenCode port 10004 routing Apr 15, 2026

Copilot AI requested a review from lpcox April 15, 2026 03:16

Copilot finished work on behalf of lpcox April 15, 2026 03:16

lpcox marked this pull request as ready for review April 15, 2026 04:02

Copilot AI review requested due to automatic review settings April 15, 2026 04:02

lpcox requested a review from Mossaka as a code owner April 15, 2026 04:02

Copilot started reviewing on behalf of lpcox April 15, 2026 04:03 View session

This comment has been minimized.

Sign in to view

github-actions bot added smoke-claude smoke-copilot labels Apr 15, 2026

This comment has been minimized.

Sign in to view

github-actions bot added the smoke-services label Apr 15, 2026

github-actions bot mentioned this pull request Apr 15, 2026

[aw] No-Op Runs #1983

Open

Copilot AI reviewed Apr 15, 2026

View reviewed changes

containers/api-proxy/server.js Outdated Show resolved Hide resolved

containers/api-proxy/server.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

github-actions bot added the build-test label Apr 15, 2026

lpcox and others added 2 commits April 14, 2026 21:08

Update containers/api-proxy/server.js

21e990d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update containers/api-proxy/server.js

4b76ccd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lpcox merged commit 063f128 into main Apr 15, 2026
53 of 56 checks passed

lpcox deleted the copilot/fix-review-comments-1979 branch April 15, 2026 04:27

github-actions bot mentioned this pull request Apr 15, 2026

fix(api-proxy): OpenCode port 10004 defaults to Copilot/OpenAI routing instead of Anthropic #1979

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(api-proxy): address review comments on OpenCode port 10004 routing#1984

fix(api-proxy): address review comments on OpenCode port 10004 routing#1984
lpcox merged 8 commits intomainfrom
copilot/fix-review-comments-1979

Copilot AI commented Apr 15, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

🔥 Smoke Test Results

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Smoke Test: GitHub Actions Services Connectivity

Uh oh!

github-actions bot commented Apr 15, 2026

Chroot Version Comparison Results

Uh oh!

github-actions bot commented Apr 15, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 15, 2026 •

edited

Loading