Skip to content

Address review comments

33e89ea
Select commit
Loading
Failed to load commit list.
Merged

Add tree-sitter-swift extractor scaffolding and YEAST desugaring #21812

Address review comments
33e89ea
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed May 8, 2026 in 5s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 60 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 60 in unified/ql/lib/codeql/Locations.qll

See this annotation in the file changed.

Code scanning / CodeQL

Cannot inline predicate across overlay frontier Warning

This possibly local non-private inline predicate will not be inlined across the overlay frontier. This may negatively affect evaluation performance. Consider adding an overlay[caller] or overlay[caller?] annotation to allow inlining across the overlay frontier. Note that adding an overlay[caller] or overlay[caller?] annotation affects semantics under overlay evaluation.

Check warning on line 102 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 114 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 129 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions element

Check warning on line 141 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions element

Check warning on line 224 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions default_value

Check warning on line 229 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions must_inherit

Check warning on line 309 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 327 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 515 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 531 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 594 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 604 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 804 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 814 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 859 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions data_contents

Check warning on line 867 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions raw_value

Check warning on line 905 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions constrained_type

Check warning on line 910 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions must_equal

Check warning on line 933 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions lhs

Check warning on line 949 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions rhs

Check warning on line 988 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions collection

Check warning on line 1031 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions default_value

Check warning on line 1039 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions return_type

Check warning on line 1072 in unified/ql/lib/codeql/unified/Ast.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for i, but the QLDoc mentions return_type