Skip to content

Mark Swift incompatible OS as configuration error #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 5 commits into from
Apr 9, 2026
Merged

Mark Swift incompatible OS as configuration error #3801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f323ca
Mark Swift incompatible OS as configuration error
henrymercer Apr 2, 2026
e452857
Throw error early rather than warning
henrymercer Apr 8, 2026
808513f
Update language aliases test
henrymercer Apr 8, 2026
43d8420
Do not run Swift in debug artifacts after failure check
henrymercer Apr 9, 2026
5a17511
Throw error on Windows too
henrymercer Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions src/init-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,15 @@ async function run(startedAt: Date) {
logger,
});

if (
config.languages.includes(KnownLanguage.swift) &&
process.platform === "linux"
) {
throw new ConfigurationError(
`Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner.`,
);
}
Comment on lines +392 to +399
Copy link
Copy Markdown
Member

@mbg mbg Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if someone tries to analyse Swift on Windows? Should that also result in an error here? I imagine that the warning was specifically because we used to support Swift analysis on Linux. Now that we are turning this into an error to fail an analysis early, should we include Windows as well?

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we might as well :)


if (repositoryPropertiesResult.isFailure()) {
addNoLanguageDiagnostic(
config,
Expand Down Expand Up @@ -499,15 +508,6 @@ async function run(startedAt: Date) {
);
}

if (
config.languages.includes(KnownLanguage.swift) &&
process.platform === "linux"
) {
logger.warning(
`Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner if this affects you.`,
);
}

if (
config.languages.includes(KnownLanguage.go) &&
process.platform === "linux"
Expand Down
Loading