Skip to content

Address missing telemetry at the start of Actions #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 10 commits into from
Jan 23, 2026
Merged

Address missing telemetry at the start of Actions #3415

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7c72e12
Expand try-catch to cover more of Actions
henrymercer Jan 22, 2026
b715292
Move config saving within try-catch
henrymercer Jan 22, 2026
14bd767
Add reminder to minimise code outside try/catch
henrymercer Jan 22, 2026
229e0cd
Add catch-all error reporting for errors that slip through `run`
henrymercer Jan 22, 2026
6bd84b6
Rename to "unhandled"
henrymercer Jan 23, 2026
529c266
Use `getErrorMessage` in more places
henrymercer Jan 23, 2026
edebb78
Differentiate unhandled errors in telemetry
henrymercer Jan 23, 2026
91f3460
Throw if in test mode
henrymercer Jan 23, 2026
28bfb7b
Omit error from start-proxy Action
henrymercer Jan 23, 2026
fba7872
Address review comments
henrymercer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/autobuild-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/init-action-post.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/init-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/resolve-environment-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/setup-codeql-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/start-proxy-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib/upload-sarif-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions src/status-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,10 +630,17 @@ export async function sendUnhandledErrorStatusReport(
);
if (statusReport !== undefined) {
await sendStatusReport(statusReport);
} else if (isInTestMode()) {
throw new Error(
"Failed to create status report for unhandled error in test mode.",
);
Copy link
Copy Markdown
Member

@mbg mbg Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intuitively this is unnecessary, because createStatusReportBase throws if isInTestMode() is true, so we should never have the statusReport === undefined case there.

Did you add this deliberately to catch a potential scenario where createStatusReportBase doesn't throw in test mode, but statusReport is undefined anyway?

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add this deliberately to catch a potential scenario where createStatusReportBase doesn't throw in test mode, but statusReport is undefined anyway?

Yes, but this is probably overly defensive. I'll remove it.

}
} catch (e) {
logger.warning(
`Failed to send the error status report: ${getErrorMessage(e)}.`,
Copy link
Copy Markdown
Member

@mbg mbg Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Perhaps add "unhandled" before "error status report", so it's more obvious what this log message relates to.

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd originally held off since this is customer facing, but it's probably not confusing in retrospect.

);
if (isInTestMode()) {
throw e;
}
}
}