Skip to content

Only run PR checks on Ubuntu by default #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 11 commits into from
Sep 25, 2025
Merged

Only run PR checks on Ubuntu by default #3137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3df8072
Only run PR checks on Ubuntu by default
henrymercer Sep 23, 2025
29a4b87
Run code scanning config tests on Linux only
henrymercer Sep 23, 2025
1b12ed7
Run resolve environment PR checks cross-platform
henrymercer Sep 23, 2025
67a0080
Test all-platform bundle on all platforms
henrymercer Sep 24, 2025
79bbb17
Remove PR checks that are now duplicated
henrymercer Sep 24, 2025
8633a15
Remove unnecessary "test" prefix from check names
henrymercer Sep 24, 2025
ba58de7
Run resolve environment test against Ubuntu only
henrymercer Sep 24, 2025
83fdfaf
Merge branch 'main' into henrymercer/slim-pr-checks
henrymercer Sep 24, 2025
4082f8c
Install yq
henrymercer Sep 24, 2025
a34e1cd
Merge branch 'main' into henrymercer/slim-pr-checks
henrymercer Sep 24, 2025
5445d1a
Merge branch 'main' into henrymercer/slim-pr-checks
henrymercer Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/__build-mode-autobuild.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pr-checks/checks/build-mode-autobuild.yml
View file
Open in desktop
Copy link
Copy Markdown
Member

@mbg mbg Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this test be combined with one of autobuild-direct-tracing*? Seems similar.

Alternatively, maybe we could combine the three build-mode tests in one workflow with a matrix (and conditional steps based on the build-mode) / sequential jobs.

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this test be combined with one of autobuild-direct-tracing*? Seems similar.

I've combined with autobuild-direct-tracing now that we will use direct tracing by default. But with the specific working directory it might still be useful to check build-mode: autobuild respects the working directory.

Alternatively, maybe we could combine the three build-mode tests in one workflow with a matrix (and conditional steps based on the build-mode) / sequential jobs.

We could, but we could no longer generate the workflow, so won't do for now.

Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ steps:
languages: java
tools: ${{ steps.prepare-test.outputs.tools-url }}

- name: Install yq
if: runner.os == 'Windows'
run: |
choco install yq -y
Comment thread
mbg marked this conversation as resolved.
- name: Validate database build mode
run: |
metadata_path="$RUNNER_TEMP/customDbLocation/java/codeql-database.yml"
Expand Down
Loading