save config / factory reset

[edipascale]

not yet implemented for Cumulus; nothing calls these for the moment

Part of https://github.com/githedgehog/internal/issues/417

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4edc4571-3deb-422a-896a-844014d2d974

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🚀 Temp artifacts published: v0-d7a6d524c 🚀

[Copilot]

Pull request overview

Adds “save running config” support to the dozer.Processor abstraction and implements initial SONiC-based save/reset behaviors for Broadcom and Celestica+ platforms (with Cumulus left as unsupported for now).

Changes:

• Extend dozer.Processor with a SaveConfig(ctx) method.
• Implement Broadcom FactoryReset via PTY-backed execution and add Broadcom SaveConfig.
• Implement Celestica+ FactoryReset/SaveConfig; add Cumulus SaveConfig stub.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
pkg/agent/dozer/dozer.go	Adds SaveConfig to the Processor interface.
pkg/agent/dozer/bcm/processor.go	Implements Broadcom FactoryReset and introduces SaveConfig via sonic-cli.
pkg/agent/cmls/processor.go	Adds SaveConfig stub returning unsupported.
pkg/agent/clsp/processor.go	Implements Celestica+ FactoryReset and SaveConfig via sonic-cli.

Comments suppressed due to low confidence (1)

pkg/agent/clsp/processor.go:122

• exec.CommandContext does not perform shell parsing; the embedded quotes in "copy running-config startup-config" will be passed literally and can break sonic-cli -c. Pass the full command as a single argument without embedded quotes.

	cmd := exec.CommandContext(ctx, "sonic-cli", "-c", "\"copy running-config startup-config\"")

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

🚀 Temp artifacts published: v0-b20fde652 🚀