Skip to content

Nvidia hardware profile #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrbojangles3 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Nvidia hardware profile #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
998f93a
feat: add support for sn4600 and sn3700c, profiles,and tests
mrbojangles3 Mar 20, 2026
8555bac
fix: remove hard coded port number
mrbojangles3 Apr 1, 2026
69a6443
fix: add flag to ignore existing dir
mrbojangles3 Apr 3, 2026
3b8d1ae
fix: update port count to match largest switch
mrbojangles3 Apr 6, 2026
fe9b992
feat: add sn2201 switch profile
mrbojangles3 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
268 changes: 164 additions & 104 deletions api/wiring/v1beta1/switchprofile_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const (
ManagementPortNOSNamePrefix = "Management"
DataPortPrefix = "E"
DataPortNOSNamePrefix = "Ethernet"
DataPortCmlsNamePrefix = "swp"
BreakoutNOSNamePrefix = "1/"
ONIEPortNamePrefix = "eth"

Expand Down Expand Up @@ -286,61 +287,67 @@ func (sp *SwitchProfile) Validate(_ context.Context, _ kclient.Reader, _ *meta.F
}
nosPortNames[port.NOSName] = true

if port.BaseNOSName != "" {
if _, ok := baseNOSPortNames[port.BaseNOSName]; ok {
return nil, errors.Errorf("port %q base NOS name %q is duplicated", name, port.BaseNOSName)
if sp.Spec.NOSType != meta.NOSTypeCumulusMlx && sp.Spec.NOSType != meta.NOSTypeCumulusVX {
if port.BaseNOSName != "" {
if _, ok := baseNOSPortNames[port.BaseNOSName]; ok {
return nil, errors.Errorf("port %q base NOS name %q is duplicated", name, port.BaseNOSName)
}
baseNOSPortNames[port.BaseNOSName] = true
}
baseNOSPortNames[port.BaseNOSName] = true
}

if port.Management {
if !strings.HasPrefix(name, ManagementPortPrefix) {
return nil, errors.Errorf("management port %q name must start with M", name)
}
if sp.Spec.NOSType == meta.NOSTypeCumulusMlx || sp.Spec.NOSType == meta.NOSTypeCumulusVX {
if port.NOSName != "eth0" {
return nil, errors.Errorf("management port %q name must be eth0 in Cumulus", name)
}
} else {
if !strings.HasPrefix(name, ManagementPortPrefix) {
return nil, errors.Errorf("management port %q name must start with M", name)
}

if port, err := strconv.Atoi(name[1:]); err != nil || port <= 0 {
return nil, errors.Errorf("management port %q name must end with a positive integer", name)
}
if port, err := strconv.Atoi(name[1:]); err != nil || port <= 0 {
return nil, errors.Errorf("management port %q name must end with a positive integer", name)
}

if !strings.HasPrefix(port.NOSName, ManagementPortNOSNamePrefix) {
return nil, errors.Errorf("management port %q NOS name must start with Management", name)
}
if !strings.HasPrefix(port.NOSName, ManagementPortNOSNamePrefix) {
return nil, errors.Errorf("management port %q NOS name must start with Management", name)
}

if port, err := strconv.Atoi(port.NOSName[len(ManagementPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("management port %q NOS name must end with a positive integer", name)
}
if port, err := strconv.Atoi(port.NOSName[len(ManagementPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("management port %q NOS name must end with a positive integer", name)
}

if port.OniePortName == "" {
return nil, errors.Errorf("management port %q must have an ONIE port name", name)
}
if port.OniePortName == "" {
return nil, errors.Errorf("management port %q must have an ONIE port name", name)
}
Comment thread
mrbojangles3 marked this conversation as resolved.

if !strings.HasPrefix(port.OniePortName, ONIEPortNamePrefix) {
return nil, errors.Errorf("management port %q ONIE port name must start with eth", name)
}
if !strings.HasPrefix(port.OniePortName, ONIEPortNamePrefix) {
return nil, errors.Errorf("management port %q ONIE port name must start with eth", name)
}

if port, err := strconv.Atoi(port.OniePortName[len(ONIEPortNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("management port %q ONIE port name must end with a zero or positive integer", name)
}
if port, err := strconv.Atoi(port.OniePortName[len(ONIEPortNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("management port %q ONIE port name must end with a zero or positive integer", name)
}

if port.Group != "" {
return nil, errors.Errorf("management port %q must not have a group", name)
}
if port.Group != "" {
return nil, errors.Errorf("management port %q must not have a group", name)
}

if port.Profile != "" {
return nil, errors.Errorf("management port %q must not have a profile", name)
}
if port.Profile != "" {
return nil, errors.Errorf("management port %q must not have a profile", name)
}

if port.BaseNOSName != "" {
return nil, errors.Errorf("management port %q must not have a base NOS name", name)
if port.BaseNOSName != "" {
return nil, errors.Errorf("management port %q must not have a base NOS name", name)
}
Comment thread
mrbojangles3 marked this conversation as resolved.
}

continue
}

if !strings.HasPrefix(name, DataPortPrefix) {
return nil, errors.Errorf("data port %q must start with E", name)
}

portParts := strings.Split(name[len(DataPortPrefix):], "/")
if len(portParts) != 2 {
return nil, errors.Errorf("data port %q name must have two segments separated by a slash (e.g. asic/port)", name)
Expand Down Expand Up @@ -385,24 +392,26 @@ func (sp *SwitchProfile) Validate(_ context.Context, _ kclient.Reader, _ *meta.F
return nil, errors.Errorf("breakout port %q must have a NOS name", name)
}

if !strings.HasPrefix(port.NOSName, BreakoutNOSNamePrefix) {
return nil, errors.Errorf("breakout port %q NOS name must start with %s", name, BreakoutNOSNamePrefix)
}

if _, err := strconv.Atoi(port.NOSName[len(BreakoutNOSNamePrefix):]); err != nil {
return nil, errors.Errorf("breakout port %q NOS name must end with a positive integer", name)
if sp.Spec.NOSType != meta.NOSTypeCumulusMlx && sp.Spec.NOSType != meta.NOSTypeCumulusVX {
if !strings.HasPrefix(port.NOSName, BreakoutNOSNamePrefix) {
return nil, errors.Errorf("breakout port %q NOS name must start with %s", name, BreakoutNOSNamePrefix)
}
if _, err := strconv.Atoi(port.NOSName[len(BreakoutNOSNamePrefix):]); err != nil {
return nil, errors.Errorf("breakout port %q NOS name must end with a positive integer", name)
}
}

if port.BaseNOSName == "" {
return nil, errors.Errorf("breakout port %q must have a base NOS name", name)
}
if sp.Spec.NOSType != meta.NOSTypeCumulusMlx && sp.Spec.NOSType != meta.NOSTypeCumulusVX {
if !strings.HasPrefix(port.BaseNOSName, DataPortNOSNamePrefix) {
return nil, errors.Errorf("breakout port %q base NOS name must start with %s", name, DataPortNOSNamePrefix)
}

if !strings.HasPrefix(port.BaseNOSName, DataPortNOSNamePrefix) {
return nil, errors.Errorf("breakout port %q base NOS name must start with %s", name, DataPortNOSNamePrefix)
}

if port, err := strconv.Atoi(port.BaseNOSName[len(DataPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("breakout port %q base NOS name must end with a zero or positive integer", name)
if port, err := strconv.Atoi(port.BaseNOSName[len(DataPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("breakout port %q base NOS name must end with a zero or positive integer", name)
}
}
}
}
Expand All @@ -419,12 +428,14 @@ func (sp *SwitchProfile) Validate(_ context.Context, _ kclient.Reader, _ *meta.F
}

if !isBreakout {
if !strings.HasPrefix(port.NOSName, DataPortNOSNamePrefix) {
return nil, errors.Errorf("data port %q NOS name must start with %s", name, DataPortNOSNamePrefix)
}
if sp.Spec.NOSType != meta.NOSTypeCumulusMlx && sp.Spec.NOSType != meta.NOSTypeCumulusVX {
if !strings.HasPrefix(port.NOSName, DataPortNOSNamePrefix) {
return nil, errors.Errorf("data port %q NOS name must start with %s", name, DataPortNOSNamePrefix)
}

if port, err := strconv.Atoi(port.NOSName[len(DataPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("data port %q NOS name must end with a zero or positive integer", name)
if port, err := strconv.Atoi(port.NOSName[len(DataPortNOSNamePrefix):]); err != nil || port < 0 {
return nil, errors.Errorf("data port %q NOS name must end with a zero or positive integer", name)
}
}
}

Expand Down Expand Up @@ -626,38 +637,52 @@ func (sp *SwitchProfileSpec) GetAPI2NOSPortsFor(sw *SwitchSpec) (map[string]stri

continue
}

if port.Profile != "" && sp.PortProfiles[port.Profile].Breakout != nil {
breakoutProfile := sp.PortProfiles[port.Profile].Breakout

swBreakout, ok := sw.PortBreakouts[portName]
if !ok {
swBreakout = breakoutProfile.Default
}

if breakoutMode, ok := breakoutProfile.Supported[swBreakout]; ok {
nosNameBaseStr, cut := strings.CutPrefix(port.BaseNOSName, DataPortNOSNamePrefix)
if !cut {
return nil, errors.Errorf("port %q base NOS name %q is invalid (no expected prefix)", portName, port.NOSName)
}
nosNameBase, err := strconv.Atoi(nosNameBaseStr)
if err != nil {
return nil, errors.Errorf("port %q base NOS name %q is invalid (suffix isn't a number)", portName, port.NOSName)
}

for breakoutIdx, offsetStr := range breakoutMode.Offsets {
offset, err := strconv.Atoi(offsetStr)
if sp.NOSType == meta.NOSTypeCumulusMlx || sp.NOSType == meta.NOSTypeCumulusVX {
for breakoutIdx, offsetStr := range breakoutMode.Offsets {
nosName := port.BaseNOSName + port.NOSName
switch {
case offsetStr == "":
ports[portName] = nosName
ports[fmt.Sprintf("%s/%d", portName, breakoutIdx+1)] = nosName
case offsetStr == "0":
ports[portName] = nosName + "s" + offsetStr
ports[fmt.Sprintf("%s/%d", portName, breakoutIdx+1)] = nosName + "s" + offsetStr
default:
ports[fmt.Sprintf("%s/%d", portName, breakoutIdx+1)] = nosName + "s" + offsetStr
}
}
} else {
nosNameBaseStr, cut := strings.CutPrefix(port.BaseNOSName, DataPortNOSNamePrefix)
if !cut {
return nil, errors.Errorf("port %q base NOS name %q is invalid (no expected prefix)", portName, port.NOSName)
}
nosNameBase, err := strconv.Atoi(nosNameBaseStr)
if err != nil {
return nil, errors.Errorf("port %q NOS name %q breakout mode %q offset %q is invalid (not a number)", portName, port.NOSName, swBreakout, offsetStr)
return nil, errors.Errorf("port %q base NOS name %q is invalid (suffix isn't a number)", portName, port.NOSName)
}
Comment on lines +663 to 670

Copilot AI Mar 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These errors are reporting the wrong value: they say “base NOS name %q” but format port.NOSName. This makes debugging invalid BaseNOSName values hard. Use port.BaseNOSName in both messages so the user sees the actual base name that failed parsing.

Copilot uses AI. Check for mistakes.

nosName := fmt.Sprintf("%s%d", DataPortNOSNamePrefix, nosNameBase+offset)
for breakoutIdx, offsetStr := range breakoutMode.Offsets {
offset, err := strconv.Atoi(offsetStr)
if err != nil {
return nil, errors.Errorf("port %q NOS name %q breakout mode %q offset %q is invalid (not a number)", portName, port.NOSName, swBreakout, offsetStr)
}

if breakoutIdx == 0 {
ports[portName] = nosName
}
nosName := fmt.Sprintf("%s%d", DataPortNOSNamePrefix, nosNameBase+offset)

if breakoutIdx == 0 {
ports[portName] = nosName
}

ports[fmt.Sprintf("%s/%d", portName, breakoutIdx+1)] = nosName
ports[fmt.Sprintf("%s/%d", portName, breakoutIdx+1)] = nosName
}
}
} else {
return nil, errors.Errorf("port %q has a breakout %q not supported by profile %q", portName, swBreakout, port.Profile)
Expand All @@ -677,27 +702,50 @@ func (sp *SwitchProfileSpec) GetNOS2APIPortsFor(sw *SwitchSpec) (map[string]stri
if sw == nil {
return nil, errors.Errorf("switch spec is nil")
}

api2NOS, err := sp.GetAPI2NOSPortsFor(sw)
if err != nil {
return nil, errors.Wrap(err, "failed to get API to NOS ports")
}

ports := map[string]string{}
for apiPort, nosPort := range api2NOS {
if prevAPIPort, exists := ports[nosPort]; exists {
if prevAPIPort+"/1" == apiPort {
ports[nosPort] = apiPort

continue
} else if prevAPIPort == apiPort+"/1" {
continue
}

return nil, errors.Errorf("NOS port %q is duplicated", nosPort)
if sp.NOSType == meta.NOSTypeCumulusMlx || sp.NOSType == meta.NOSTypeCumulusVX {
for portName, port := range sp.Ports {
if port.Management {
ports[port.NOSName] = "M1"
}
if port.Profile != "" && sp.PortProfiles[port.Profile].Breakout != nil {
breakoutProfile := sp.PortProfiles[port.Profile].Breakout
swBreakout, ok := sw.PortBreakouts[portName]
if !ok {
swBreakout = breakoutProfile.Default
}
if breakoutMode, ok := breakoutProfile.Supported[swBreakout]; ok {
for breakoutIdx, offsetStr := range breakoutMode.Offsets {
switch {
case offsetStr == "":
ports[port.BaseNOSName+port.NOSName] = "E1/" + port.NOSName + "/1"
default:
ports[port.BaseNOSName+port.NOSName+"s"+offsetStr] = "E1/" + port.NOSName + "/" + strconv.Itoa(breakoutIdx+1)
}
}
}
}
}
} else {
api2NOS, err := sp.GetAPI2NOSPortsFor(sw)
if err != nil {
return nil, errors.Wrap(err, "failed to get API to NOS ports")
}
for apiPort, nosPort := range api2NOS {
if prevAPIPort, exists := ports[nosPort]; exists {
if prevAPIPort+"/1" == apiPort {
ports[nosPort] = apiPort

continue
} else if prevAPIPort == apiPort+"/1" {
continue
}

ports[nosPort] = apiPort
return nil, errors.Errorf("NOS port %q is duplicated", nosPort)
}
ports[nosPort] = apiPort
}
}

return ports, nil
Expand Down Expand Up @@ -753,24 +801,36 @@ func (sp *SwitchProfileSpec) GetAllBreakoutNOSNames() (map[string]bool, error) {
continue
}

nosNameBaseStr, cut := strings.CutPrefix(port.BaseNOSName, DataPortNOSNamePrefix)
if !cut {
return nil, errors.Errorf("port %q base NOS name %q is invalid (no expected prefix)", portName, port.NOSName)
}
nosNameBase, err := strconv.Atoi(nosNameBaseStr)
if err != nil {
return nil, errors.Errorf("port %q base NOS name %q is invalid (suffix isn't a number)", portName, port.NOSName)
}

for _, breakoutMode := range profile.Breakout.Supported {
for _, offsetStr := range breakoutMode.Offsets {
offset, err := strconv.Atoi(offsetStr)
if err != nil {
return nil, errors.Errorf("port %q NOS name %q breakout mode %q offset %q is invalid (not a number)", portName, port.NOSName, breakoutMode, offsetStr)
if sp.NOSType == meta.NOSTypeCumulusMlx || sp.NOSType == meta.NOSTypeCumulusVX {
for _, breakoutMode := range profile.Breakout.Supported {
for _, offsetStr := range breakoutMode.Offsets {
if offsetStr == "" {
continue
}
nosName := port.BaseNOSName + port.NOSName + "s" + offsetStr
ports[nosName] = true
}
}
} else {
nosNameBaseStr, cut := strings.CutPrefix(port.BaseNOSName, DataPortNOSNamePrefix)
if !cut {
return nil, errors.Errorf("port %q base NOS name %q is invalid (no expected prefix)", portName, port.NOSName)
}
nosNameBase, err := strconv.Atoi(nosNameBaseStr)
if err != nil {
return nil, errors.Errorf("port %q base NOS name %q is invalid (suffix isn't a number)", portName, port.NOSName)
}

for _, breakoutMode := range profile.Breakout.Supported {
for _, offsetStr := range breakoutMode.Offsets {
offset, err := strconv.Atoi(offsetStr)
if err != nil {
return nil, errors.Errorf("port %q NOS name %q breakout mode %q offset %q is invalid (not a number)", portName, port.NOSName, breakoutMode, offsetStr)
}

nosName := fmt.Sprintf("%s%d", DataPortNOSNamePrefix, nosNameBase+offset)
ports[nosName] = true
nosName := fmt.Sprintf("%s%d", DataPortNOSNamePrefix, nosNameBase+offset)
ports[nosName] = true
}
}
}
}
Expand Down
Loading
Loading