quick fix: flow filter printer - #1679
Check failed
There are 15 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | 1c4b32d | refactor(flow-filter): key the routing tables on V... | Valid sign-off found |
| 🟢 | aea4dd8 | feat(match-action): render rules from their typed ... | Valid sign-off found |
| 🟢 | 259678d | feat(flow-filter,acl-filter): dump installed rules... | Valid sign-off found |
| 🔴 | 574a261 | refactor(flow-filter): show rule rank, not the int... | Sign-off not found |
| 🔴 | 948a254 | fix(match-action): render partial masks as the bit... | Sign-off not found |
| 🔴 | 54882d9 | refactor(match-action): give masks their own const... | Sign-off not found |
| 🔴 | 72d21b9 | test(flow-filter,acl-filter): DO NOT MERGE -- rule... | Sign-off not found |
| 🔴 | 95aff00 | test(acl-filter): property-test ACL lowering again... | Sign-off not found |
| 🔴 | a4b480e | test(flow-filter): carry the config oracle through... | Sign-off not found |
| 🔴 | 6eebc5b | fix(acl): bound the layout stride from above, not ... | Sign-off not found |
| 🔴 | 13f65ec | test(flow-filter): fuzz the NF's parser-facing edg... | Sign-off not found |
| 🔴 | f88ddb0 | test(flow-filter): generate exclusion prefixes, so... | Sign-off not found |
| 🔴 | 7e54e60 | test(flow-filter): pin two edges the property suit... | Sign-off not found |
| 🔴 | 14c61ff | fix(acl-filter): file each ACL rule by its own IP ... | Sign-off not found |
| 🔴 | a6ddeba | fix(flow-filter): a catch-all expose covers every ... | Sign-off not found |
| 🔴 | 6a6990e | fix(flow-filter): verify a masquerade destination,... | Sign-off not found |
| 🔴 | 7efb932 | fix(flow-filter): bound rte_acl table names for ev... | Sign-off not found |
| 🔴 | 054501d | test(flow-filter): generate cross-peering masquera... | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~18 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pr/daniel-noland/quick-fix-fuzz-and-print