augment hash to consider icmp ids - #1676
Open
Fredi-raspall wants to merge 1 commit into
Open
Conversation
Augment the hash method for ip packets to consider the ICMP id field (if present). This adds entropy and allows spraying ICMP traffic over ECMP legs. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesICMP hashing
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the IP packet hashing logic to incorporate the ICMP identifier (when present) so that ICMP query traffic (e.g., Echo) gains additional entropy for improved ECMP spreading.
Changes:
- Extend
Packet::hash_ipto hash the ICMPv4 identifier when available. - Extend
Packet::hash_ipto hash the ICMPv6 identifier when available.
Comment on lines
+41
to
+50
| Transport::Icmp4(icmp4) => { | ||
| if let Some(id) = icmp4.identifier() { | ||
| id.hash(state); | ||
| } | ||
| } | ||
| Transport::Icmp6(icmp6) => { | ||
| if let Some(id) = icmp6.identifier() { | ||
| id.hash(state); | ||
| } | ||
| } |
qmonnet
approved these changes
Jul 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Augment the hash method for ip packets to consider the ICMP id field (if present). This adds entropy and allows spraying ICMP traffic over ECMP legs.