-
Notifications
You must be signed in to change notification settings - Fork 260
Show pending checkpoint processing in status #2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6544,6 +6544,7 @@ impl ActorDaemonCoordinator { | |
| last_error: status | ||
| .last_error | ||
| .or_else(|| self.latest_side_effect_error(&family_key).ok().flatten()), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Status warns about pending work even when the pending work belongs to a different repository The pending-work count reported for a specific repository is actually the background service's global count of unfinished checkpoints across every repository ( Global ingress quota vs. family-scoped response field
A family-scoped count would need to be derived from per-family sequencer state (e.g. counting Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback. |
||
| pending_checkpoints: self.outstanding_checkpoint_state().0, | ||
| }) | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pending-work warning can be missed for work that arrives while status is being computed
Whether background processing is still pending is checked (
checkpoint_processing_pending(&repo)atsrc/commands/status.rs:61) before the attribution data is read rather than after, so work that starts during the read is displayed without any warning.Impact: Users can occasionally see incomplete attribution numbers with no indication that more processing was still happening.
Ordering of the pending probe relative to the working-log read
The probe happens first at
src/commands/status.rs:61, while the working log and checkpoints are read afterwards atsrc/commands/status.rs:70-72and the diff stats later still. If a checkpoint is accepted by the daemon between the probe and the reads, the printed status reflects a partially-processed state butcheckpoint_processing_pendingisfalse. Probing after all reads closes that window: the worst case then becomes a harmless false-positive warning (work that finished during the read) instead of a silently incomplete report.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.