Issue #373 - Add a case-sensitive search checkbox - #47
Merged
Conversation
- Added a "Case Sensitive" checkbox next to "Search Description" in the search toolbar. It is unchecked by default and follows the same sensitivity rules as the other search widgets. - search_packages() now takes a case_sensitive argument, passing -C to pkg search when checked and -i when unchecked. Previously no case flag was passed, so the result depended on the CASE_SENSITIVE_MATCH setting of pkg. - Regenerated po/software-station.pot and merged the catalogs. The new strings "Case Sensitive" and "Match the search case exactly" still need translation. Closes ghostbsd/issues#373
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR adds a default-off case-sensitive search option to the toolbar, propagates it into package searches, and explicitly selects Sequence diagram for case-sensitive package searchsequenceDiagram
actor User
participant SearchToolbar
participant search_packages
participant pkg
User->>SearchToolbar: Enter search and choose Case Sensitive
SearchToolbar->>search_packages: search_packages(search, descriptions, case_sensitive)
alt case_sensitive is true
search_packages->>pkg: pkg search -U -C -Q name search
else case_sensitive is false
search_packages->>pkg: pkg search -U -i -Q name search
end
pkg-->>search_packages: Matching package names
search_packages-->>SearchToolbar: Search results
SearchToolbar-->>User: Display results
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ghostbsd/issues#373
Summary by Sourcery
Add explicit case-sensitivity control to package searches and update translation resources.
New Features:
Bug Fixes:
Chores: