gguf : reject non-u32 general.alignment#24988
Open
Adel-Ayoub wants to merge 1 commit into
Open
Conversation
|
Hi @Adel-Ayoub, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A GGUF file whose
general.alignmentkey is stored with a non-u32type (or as anarray) crashes the loader instead of being rejected.
gguf_init_from_reader()reads itvia
gguf_get_val_u32(), which asserts the stored type (ggml/src/gguf.cpp:194);GGML_ASSERTcallsabort()in release builds, so a corrupt/crafted model takes downevery
gguf_init_from_*caller (llama-cli,llama-server, ...) with SIGABRT.The u32 requirement is already enforced on the write side (
gguf_check_reserved_keys),and the bad-value case is already rejected gracefully two lines below — this does the
same for a bad type: validate it and
return nullptr.Before / after, loading a GGUF with an
int32general.alignment:Additional information
Adds a
HANDCRAFTED_KV_BAD_ALIGN_TYPEregression case totests/test-gguf.cpp.ctest -R ggufpasses.Requirements