fix(native): Omit outermost nullish frames - #2041
Open
Dav1dde wants to merge 1 commit into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/remove-4k-frames
branch
from
September 2, 2026 21:55
68d73ad to
f938d87
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f938d87. Configure here.
| frame.addr_mode == AddrMode::Abs && frame.instruction_addr.0 < 4096; | ||
| if status == FrameStatus::UnknownImage && is_outermost_frame && is_nullish { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Lone null-IP crash frame dropped
Medium Severity
The new filter drops an outermost UnknownImage frame when instruction_addr is below 4096, even if it is the only frame. rust-minidump uses that check only to stop walking callers and still keeps the context frame, so a null-IP crash with no further unwind can lose its entire stack.
Reviewed by Cursor Bugbot for commit f938d87. Configure here.
loewenheim
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very similar to #2040 and addresses the same stack trace:
But it has a slightly different behaviour which catches cases of bogus frames even if the previous frame isn't a well known glibc frame.
Applies Rust Minidump's stack walking behaviour also to client side unwound frames: