feat(variables): Begin reading minidump memory for variables - #2035
1 issue
wrdn-dos-review: Found 1 issue (1 medium)
Medium
Variable extraction materializes attacker-sized memory dumps without an output cap - `crates/symbolicator-native/src/symbolication/native.rs:60`
When variable extraction is enabled, a SymCache-derived primitive or pointer size controls the minidump range read for a frame-offset variable. Although the memory accessor checks that the range exists, a successful range can be as large as the accepted dump and format!("{s:?}") materializes an uncapped, substantially larger String that is retained in the response, potentially exhausting worker memory.
Also found at:
crates/symbolicator-native/src/symbolication/native.rs:256-258
⏱ 21m 9s · 5.8M in / 251.2k out · $4.41
Annotations
Check warning on line 60 in crates/symbolicator-native/src/symbolication/native.rs
sentry-warden / warden: wrdn-dos-review
Variable extraction materializes attacker-sized memory dumps without an output cap
When variable extraction is enabled, a SymCache-derived primitive or pointer size controls the minidump range read for a frame-offset variable. Although the memory accessor checks that the range exists, a successful range can be as large as the accepted dump and `format!("{s:?}")` materializes an uncapped, substantially larger String that is retained in the response, potentially exhausting worker memory.
Check warning on line 258 in crates/symbolicator-native/src/symbolication/native.rs
sentry-warden / warden: wrdn-dos-review
[88N-CRQ] Variable extraction materializes attacker-sized memory dumps without an output cap (additional location)
When variable extraction is enabled, a SymCache-derived primitive or pointer size controls the minidump range read for a frame-offset variable. Although the memory accessor checks that the range exists, a successful range can be as large as the accepted dump and `format!("{s:?}")` materializes an uncapped, substantially larger String that is retained in the response, potentially exhausting worker memory.