fix(scraps): skip redundant form attribute on SubmitButton#119135
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-fd01qdcxx.sentry.dev |
natemoo-re
changed the title
SubmitButton
scttcper
approved these changes
Jul 7, 2026
natemoo-re
enabled auto-merge (squash)
July 7, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari doesn't submit a form when a
<button type="submit">has an explicitformattribute pointing at its own parent<form>. It treats the redundant association as targeting a form that doesn't exist.SubmitButtonwas unconditionally settingform={form.formId}, but since it's always rendered inside<form id={form.formId}>viaAppForm/FormWrapper, the attribute was redundant. Chrome/Firefox silently ignore the redundancy; Safari does not.This adds an
InsideFormElementcontext provided byFormWrappersoSubmitButtononly sets theformattribute when it's actually rendered outside the<form>element — preserving support for that pattern without breaking Safari.Closes #119114
Closes DE-1353