fix(conversations): Redesign the timeline loading skeleton#119103
Draft
priscilawebdev wants to merge 3 commits into
Draft
fix(conversations): Redesign the timeline loading skeleton#119103priscilawebdev wants to merge 3 commits into
priscilawebdev wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Add ConversationViewSkeletonNew, a loading placeholder for the redesigned timeline tab that mirrors the real AiSpanTimeline render: a bordered span-row card (icon, title/tool-name, optional secondary, metric + duration columns, timeline bar) on the left and the fixed-width span-detail card on the right. Wire it into ConversationViewContentNew (redesign path only) and add the missing Trace-link placeholder to the summary header skeleton. The legacy ConversationViewSkeleton is left untouched. Co-Authored-By: Claude <noreply@anthropic.com>
priscilawebdev
force-pushed
the
worktree-fix-conversation-timeline-skeleton
branch
from
e88c9c1 to
3b3d2a5
Compare
Extract ConversationTimelineLayout so the live timeline view and its loading skeleton render into the same two-column shell instead of hand-duplicating the wrapper markup, which had already started to drift (the skeleton detail header used a tighter gap than the real card). Also fix the stale comment claiming the timeline tab still uses the legacy span-detail skeleton, and key the skeleton rows by content rather than array index. Co-Authored-By: Claude <noreply@anthropic.com>
Extract SpanDetailCard so ConversationSpanDetail and the loading skeleton share the card's outer geometry (border, radius, padding, height) instead of each declaring it, keeping the box the content lands in identical across the two. Also drop null/false noise from the timeline skeleton row table via optional props. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After